ext/soap: fix make check being invoked in ext/soap#16733
Closed
Ma27 wants to merge 1 commit intophp:masterfrom
Closed
ext/soap: fix make check being invoked in ext/soap#16733Ma27 wants to merge 1 commit intophp:masterfrom
make check being invoked in ext/soap#16733Ma27 wants to merge 1 commit intophp:masterfrom
Conversation
On NixOS we run `make` & `make check` inside `ext/soap` which broke the test
like this:
001+ Fatal error: Uncaught SoapFault exception: [WSDL] SOAP-ERROR: Parsing WSDL: Couldn't load from 'ext/soap/tests/gh15711.wsdl' : failed to load "ext/soap/tests/gh15711.wsdl": No such file or directory
002+ in /build/php-8.3.13/ext/soap/tests/gh15711.php:29
003+ Stack trace:
004+ #0 /build/php-8.3.13/ext/soap/tests/gh15711.php(29): SoapClient->__construct('ext/soap/tests/...', Array)
005+ php#1 {main}
006+ thrown in /build/php-8.3.13/ext/soap/tests/gh15711.php on line 29
Fix is to make the path dependant on `__DIR__` as it's the case in other
testcases including WSDLs.
ndossche
approved these changes
Nov 8, 2024
Member
ndossche
left a comment
ndossche
left a comment
There was a problem hiding this comment.
Thanks
For the future: you need to target your PRs to the lowest supported bugfix branch. No need to change it here, I'll apply this manually to the right branches.
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On NixOS we run
make&make checkinsideext/soapwhich broke the test like this:Fix is to make the path dependant on
__DIR__as it's the case in other testcases including WSDLs.