ext/ldap: few new unit tests (tls13 protocol).#13409
Merged
devnexen merged 1 commit intophp:masterfrom Feb 16, 2024
Merged
Conversation
Member
|
I think a better idea is to split each of these tests into two files based on whether the constant is defined. Because now we're skipping on older versions, although that may be no a big deal. Wdyt? |
Member
Author
|
alright, gonna split it. |
devnexen
force-pushed
the
fix_new_ldap_test
branch
from
9e9fe17 to
c54dad8
Compare
ndossche
approved these changes
Feb 16, 2024
Member
ndossche
left a comment
ndossche
left a comment
There was a problem hiding this comment.
There's some redundancy now between the tests, an option could be to add version checks to the files such that only one variant of the two is executed.
But I think this is good enough.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.