add support for Zend Max Exeuction Timers on FreeBSD#13393
Merged
arnaud-lb merged 2 commits intophp:masterfrom Feb 16, 2024
Merged
add support for Zend Max Exeuction Timers on FreeBSD#13393arnaud-lb merged 2 commits intophp:masterfrom
arnaud-lb merged 2 commits intophp:masterfrom
Conversation
iluuu1994
approved these changes
Feb 15, 2024
Member
iluuu1994
left a comment
iluuu1994
left a comment
There was a problem hiding this comment.
LGTM /cc @arnaud-lb @devnexen
devnexen
approved these changes
Feb 15, 2024
Member
devnexen
left a comment
devnexen
left a comment
There was a problem hiding this comment.
Looking good thanks for doing this.
Member
Author
|
Thanks, but don't merge yet until we can test on a real FreeBSD. I'm on vacation with no access to a FreeBSD box. I'll test when I'll be back home. |
arnaud-lb
approved these changes
Feb 15, 2024
Member
arnaud-lb
left a comment
arnaud-lb
left a comment
There was a problem hiding this comment.
Testing on FreeBSD 13.1, CLOCK_BOOTTIME is not supported by timer_create(). According to the manpage we can use CLOCK_REALTIME or CLOCK_MONOTONIC (we could use this one as nearly equivalent for our purpose).
Other than that, after testing with apache2/mod_php it looks good to me!
Let us know when you are ready to merge.
Member
Author
|
Thanks for testing Arnaud! I updated the code. If you confirm that it works, then we can merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for the new timeout system (#10141) on FreeBSD.
See also #12814 (comment).