Support optional suffix arg in tempnam#11685
Open
athos-ribeiro wants to merge 1 commit intophp:masterfrom
Open
Support optional suffix arg in tempnam#11685athos-ribeiro wants to merge 1 commit intophp:masterfrom
athos-ribeiro wants to merge 1 commit intophp:masterfrom
Conversation
bukka
reviewed
Jul 13, 2023
Member
bukka
left a comment
bukka
left a comment
There was a problem hiding this comment.
Just added few more nits. I think the idea makes sense in general but might need a bit more time for discussion and possibly RFC as it seems it was requested before.
athos-ribeiro
force-pushed
the
tempnam-suffix
branch
from
840ccfb to
80e33b5
Compare
Contributor
Author
|
Thanks for the review, @bukka ! I addressed your nits and re-based my branch on master to fix the CI issues as well. Let's wait for possible inputs in the internals list then. I will wait a few days before starting a new RFC as well in case the original author decides to proceed with his RFC :) |
athos-ribeiro
force-pushed
the
tempnam-suffix
branch
from
80e33b5 to
661cd62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I am re-starting a discussion on tempnam suffix arg support in the internal mailing list. The idea is to either revive https://wiki.php.net/rfc/tempnam-suffix or start a new RFC to bring this one in.
There is a previous attempt to introduce a similar patch in #575.