Conversation
1 task
withinboredom
approved these changes
Feb 2, 2023
| ldconfig && \ | ||
| php --version | ||
|
|
||
| FROM php-base AS builder |
Member
There was a problem hiding this comment.
I had a feeling this would happen :)
Does this impact #133 by any chance?
I just saw 8.2.2 was released, so is this still needed?
Member
Author
There was a problem hiding this comment.
Unfortunately, we'll still need this until php/php-src#10141 isn't merged and included in a stable release. At least if we want timeouts support.
dunglas
force-pushed
the
feat/timeouts
branch
from
4c56cb6 to
9ecad92
Compare
dunglas
force-pushed
the
feat/timeouts
branch
from
9ecad92 to
f45263f
Compare
dunglas
force-pushed
the
feat/timeouts
branch
from
c866ec3 to
9ff772a
Compare
Member
Author
|
The last commit contains a refactoring of the worker code. It fixes an existing problem: in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds support for PHP timeouts (require a patch to PHP).
It also fixes some potential goroutine leaks in worker mode and contains a refactoring of the worker code.
TODO: