Repository navigation
fix(harness): correct OpenCode v2 errors and command handling - #1
Closed
tbrandenburg wants to merge 1 commit into
Closed
tbrandenburg wants to merge 1 commit into
tbrandenburg wants to merge 1 commit into
Conversation
Distinguish missing sessions from other v2 404 responses and retain snapshot file changes in the timeline. Let command preparation follow the workflow deadline rather than the generic HTTP timeout. Add regression coverage and extend real-v2 verification with a slow command and an unknown command. Follow-up to dagucloud#3367.
Author
|
@coderabbitai review |
This was referenced Oct 31, 2026
Author
|
Sorry for leaving this outdated handoff open after the upstream changes. I have adapted and verified the remaining typed-404 and snapshot fixes against current upstream main in dagucloud#3466. The command-timeout change is intentionally excluded to preserve the newer submission/cancellation guarantees. Closing this handoff in favor of that focused upstream replacement; the original branch and commit are retained. Thank you for the compatibility work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up fixes for dagucloud#3367. This PR targets your
codex/opencode-v2-compatibilitybranch so it can be merged into the existing contribution without duplicating its changes upstream.Based on
85e9c8b; one additional commit, four changed files. You can merge this PR or cherry-pickca66e59161c405aa508fe38b2f47ce42937a77dd.Changes
snapshot.filesas a stable patch event for the existing timeline and changed-file previews.Related Issues
Related to dagucloud#3367; this is not a replacement for or closure of that PR.
Validation
The snapshot, error-classification, and slow-command regression tests failed against the original implementation before applying the fixes.
Passed locally:
Formatting checks for the three modified Go files produced no differences.
Real OpenCode v2.1.4 verification, including prompt, template command, slow command, unknown command, permission approval, question answer/resume, and deletion, passed with race detection:
Latest result:
PASS, package time43.827s.Validation limits: repository-wide
make fmttimed out duringgo fix; broad lint was not completed. Harness conformance timed out building the binary before running tests. Real v1.18.11 verification repeatedly failed during startup/preflight before adapter execution; its root cause remains unresolved. No full-suite or real-v1 compatibility claim is made.Checklist