exception on naming a class "var" - #180
Merged
Merged
Conversation
"var" is no more allowed as a class name, though "Var" is. New static check for type identifier in JJAvaName, tests. Doc for the check regarding the spec. Tests required to make JDefinedclass constructors visible so package-protected instead of private/protected. Was not sure which one to use, so put them all. Tests were made before the new code and were failing, validating that the constructor did allow to build jdefined class with name "var", though there may have been more complex checks somewhere else.
glelouet
added
patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"var" is no more allowed as a class name, though "Var" is.
New static check for type identifier in JJAvaName, tests. Doc for the check regarding the spec.
Tests required to make JDefinedclass constructors visible so package-protected instead of private/protected. Was not sure which one to use, so put them all.
Tests were made before the new code and were failing, validating that the constructor did allow to build jdefined class with name "var", though there may have been more complex checks somewhere else.