Skip to content

fix #169 - #170

Merged
glelouet merged 2 commits into
phax:masterfrom
glelouet:#169
Jul 23, 2026
Merged

fix #169#170
glelouet merged 2 commits into
phax:masterfrom
glelouet:#169

Conversation

@glelouet

Copy link
Copy Markdown
Collaborator

created a new pattern var for pattern( instanceof, switch), only used in the instanceofvar

fixed final mischeck ( | instead of & ) in variable mods detection.

moved "expresssion" pck into "expressions"

created a new pattern var for pattern( instanceof, switch), only used in
the instanceofvar

fixed final mischeck ( | instead of & ) in variable mods detection.

moved "expresssion" pck into "expressions"
@glelouet glelouet closed this Jul 23, 2026
@glelouet
glelouet deleted the #169 branch July 23, 2026 16:00
@glelouet
glelouet restored the #169 branch July 23, 2026 16:05
@glelouet glelouet reopened this Jul 23, 2026
@glelouet

glelouet commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator Author

I forced my own code git pull upstream master -X ours , did not test yet

@glelouet

Copy link
Copy Markdown
Collaborator Author

tests pass, @phax you can check

@glelouet

Copy link
Copy Markdown
Collaborator Author

weirdly, I have the right to merge. Did not test the button, but I have a "merge pull request" button./

@phax

phax commented Jul 23, 2026

Copy link
Copy Markdown
Owner

Yes, you are collaborator - you can do anything

@phax

phax commented Jul 23, 2026

Copy link
Copy Markdown
Owner

Give it a try :-)

@glelouet
glelouet merged commit 4fb3cd4 into phax:master Jul 23, 2026
1 check passed
@glelouet
glelouet deleted the #169 branch July 23, 2026 16:19
@glelouet

Copy link
Copy Markdown
Collaborator Author

It's working ! IT'S WORKING !

Well, we have an agreement that I shall not use it ?

@phax

phax commented Jul 23, 2026

Copy link
Copy Markdown
Owner

Well, by giving you Collaborator, I am accepting the risk ;-)

@phax

phax commented Jul 23, 2026

Copy link
Copy Markdown
Owner

Seriously - if you want my feedback, create a PR and make me reviewer - will do my best.

@glelouet

Copy link
Copy Markdown
Collaborator Author

Seriously - if you want my feedback, create a PR and make me reviewer - will do my best.

I did not intend to do otherwise. Especially I prefer to have people review my BS since I have very opiniated coding style and am almost as farsighted and subtle as a rhinoceros.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants