chore: refresh metagame feeds - #6723
Conversation
📝 WalkthroughWalkthroughChangesThe MTGGoldfish feed snapshots are refreshed for Commander, Modern, Pioneer, and Standard. Deck ordering, archetype entries, card lists, colors, sideboards, and update timestamps are regenerated where applicable. MTGGoldfish feed refresh
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
client/public/feeds/mtggoldfish-pioneer.json (1)
249-260: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick winFeed generator emits un-merged duplicate rows for the same card name. Three decks in the Pioneer feed contain the same card twice in one list, so true per-card totals are only visible after summing rows — any per-entry copy-limit check or per-row UI render is wrong.
client/public/feeds/mtggoldfish-pioneer.json#L249-L260: merge the secondSentinel of the Nameless City,Overgrown Tomb, andCulling Ritualrows into their earlier entries inGolgari Midrange'smain.client/public/feeds/mtggoldfish-pioneer.json#L920-L923: merge thisPlainsrow into the earlierPlainsentry inOrzhov Greasefang'smain.client/public/feeds/mtggoldfish-pioneer.json#L1292-L1295: merge thisSwamprow into the earlierSwampentry inMono-Black Midrange'smain(single14-count row).🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@client/public/feeds/mtggoldfish-pioneer.json` around lines 249 - 260, Merge duplicate card rows into the earlier entry so each affected deck’s main list has one row per card with summed totals: in client/public/feeds/mtggoldfish-pioneer.json at lines 249-260, combine the duplicate Sentinel of the Nameless City, Overgrown Tomb, and Culling Ritual rows; at lines 920-923, merge the duplicate Plains row; and at lines 1292-1295, merge the duplicate Swamp row into the single 14-count entry.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@client/public/feeds/mtggoldfish-commander.json`:
- Around line 12-16: The Commander colors metadata is narrower than the cards’
color identities and must be corrected in both listed sites. In
client/public/feeds/mtggoldfish-commander.json lines 12-16, update Doctor Doom,
King of Latveria’s colors to include U, B, and R; in lines 1375-1381, update The
Ur-Dragon’s colors to include W and U alongside R, G, and B.
- Around line 3492-3495: Remove the “[DSC]” set-code suffix from the Spiked
Corridor // Torture Pit feed entry so its name is the exact card name used by
the card database. Preserve the count and other entry fields, and ensure feed
generation does not reintroduce set annotations into card names.
In `@client/public/feeds/mtggoldfish-pioneer.json`:
- Around line 1292-1295: Merge the duplicate “Swamp” entries in the feed data
into one row with a count of 14, removing the second entry while preserving the
existing card name and list structure.
- Around line 920-923: Merge the duplicate Plains entries in the feed data into
a single Plains object, summing their count values while preserving the existing
entry structure.
---
Outside diff comments:
In `@client/public/feeds/mtggoldfish-pioneer.json`:
- Around line 249-260: Merge duplicate card rows into the earlier entry so each
affected deck’s main list has one row per card with summed totals: in
client/public/feeds/mtggoldfish-pioneer.json at lines 249-260, combine the
duplicate Sentinel of the Nameless City, Overgrown Tomb, and Culling Ritual
rows; at lines 920-923, merge the duplicate Plains row; and at lines 1292-1295,
merge the duplicate Swamp row into the single 14-count entry.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 6e010f13-1311-497d-853a-bd3b59203a47
📒 Files selected for processing (4)
client/public/feeds/mtggoldfish-commander.jsonclient/public/feeds/mtggoldfish-modern.jsonclient/public/feeds/mtggoldfish-pioneer.jsonclient/public/feeds/mtggoldfish-standard.json
| "name": "Doctor Doom, King of Latveria", | ||
| "author": "MTGGoldfish", | ||
| "colors": [ | ||
| "W" | ||
| "U" | ||
| ], |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Commander colors is not derived from the decklist or the commander's color identity. Two refreshed Commander decks declare a color set narrower than the cards they contain, which misclassifies them in feed filtering and contradicts CR 903.4.
client/public/feeds/mtggoldfish-commander.json#L12-L16:Doctor Doom, King of Latveriais declared mono-Ubut the list is Grixis (Bedevil,Terminate,Dark Ritual,Vandalblast) — setcolorsto["U","B","R"].client/public/feeds/mtggoldfish-commander.json#L1375-L1381:The Ur-Dragonis declared["R","G","B"]but containsFlooded Strand,Mana Drain,Dragonlord Dromoka, andSilumgar— addWandU.
📍 Affects 1 file
client/public/feeds/mtggoldfish-commander.json#L12-L16(this comment)client/public/feeds/mtggoldfish-commander.json#L1375-L1381
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@client/public/feeds/mtggoldfish-commander.json` around lines 12 - 16, The
Commander colors metadata is narrower than the cards’ color identities and must
be corrected in both listed sites. In
client/public/feeds/mtggoldfish-commander.json lines 12-16, update Doctor Doom,
King of Latveria’s colors to include U, B, and R; in lines 1375-1381, update The
Ur-Dragon’s colors to include W and U alongside R, G, and B.
| { | ||
| "count": 1, | ||
| "name": "Ohran Frostfang" | ||
| "name": "Spiked Corridor // Torture Pit [DSC]" | ||
| }, |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Card name carries a set-code suffix, unlike every other entry in the feed.
"Spiked Corridor // Torture Pit [DSC]" embeds [DSC], so exact-name resolution against the card database will miss this entry while all sibling names resolve. Strip the set annotation during feed generation so the scraper output is uniformly exact card names.
🔧 Proposed fix
- "name": "Spiked Corridor // Torture Pit [DSC]"
+ "name": "Spiked Corridor // Torture Pit"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| { | |
| "count": 1, | |
| "name": "Ohran Frostfang" | |
| "name": "Spiked Corridor // Torture Pit [DSC]" | |
| }, | |
| { | |
| "count": 1, | |
| "name": "Spiked Corridor // Torture Pit" | |
| }, |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@client/public/feeds/mtggoldfish-commander.json` around lines 3492 - 3495,
Remove the “[DSC]” set-code suffix from the Spiked Corridor // Torture Pit feed
entry so its name is the exact card name used by the card database. Preserve the
count and other entry fields, and ensure feed generation does not reintroduce
set annotations into card names.
| { | ||
| "count": 1, | ||
| "name": "Plains" | ||
| }, |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
Second Plains entry duplicates Line 912-915.
Same un-merged-row pattern as the Golgari list; emit one entry with the summed count.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@client/public/feeds/mtggoldfish-pioneer.json` around lines 920 - 923, Merge
the duplicate Plains entries in the feed data into a single Plains object,
summing their count values while preserving the existing entry structure.
| { | ||
| "count": 7, | ||
| "name": "Swamp" | ||
| }, |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
Second Swamp entry duplicates Line 1268-1271.
7 + 7 should be a single 14-count row; splitting it repeats the un-merged-row pattern seen in the Golgari and Orzhov lists.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@client/public/feeds/mtggoldfish-pioneer.json` around lines 1292 - 1295, Merge
the duplicate “Swamp” entries in the feed data into one row with a count of 14,
removing the second entry while preserving the existing card name and list
structure.
1 participant
Automated daily metagame feed refresh from MTGGoldfish.
Summary by CodeRabbit