Fix Approach of the Second Sun: filtered SpellsCastThisGame + correct gating

[Erckdd]

Summary

Approach of the Second Sun was handing the player a win on the very first cast. The card prints:

If this spell was cast from your hand and you've cast another spell named Approach of the Second Sun this game, you win the game. Otherwise, put Approach of the Second Sun into its owner's library seventh from the top and you gain 7 life.

Three failures stacked up:

1. The parser couldn't parse the compound "this spell was cast from your hand and you've cast another spell named X this game" condition, so WinTheGame came out with condition: null and fired unconditionally.
2. There was no game-scope name-filtered history to evaluate the second half of the gate against — only an unfiltered per-player count.
3. The chunk splitter peeled "…and you gain 7 life" off the Otherwise body as a sibling clause, so even after chore: update coverage stats and badges #1 the gain-life half mis-attached to the win effect.

This PR lifts and lands all three.

What changed

Engine variant: QuantityRef::SpellsCastThisGame lifted to { scope, filter }

Mirrors the existing SpellsCastThisTurn shape (same parameterization axes within CR 117.1 — passed the add-engine-variant gate). filter: None keeps the fast O(1) state.spells_cast_this_game path used by Establishing Shot's "this is the first spell you've cast this game". filter: Some(_) scans the new game-scope history.

Game-scope history + name capture

• New SpellCastRecord.name: String (with #[serde(default)] for backwards-compat snapshots).
• New GameState.spells_cast_this_game_by_player: HashMap<PlayerId, Vec<SpellCastRecord>>, populated alongside the per-turn list in record_spell_cast_from_zone. Not cleared between turns.
• FilterProp::Named { name } now matches against the cast-time snapshot (case-insensitive), unblocking name-filtered queries on spell history.

Parser: compound condition recognition

• parse_youve_cast_another_named_this_game_condition recognises you've cast another spell named {LITERAL} this game → QuantityCheck(SpellsCastThisGame{filter=Named} >= 2). The >= 2 comparator (not 1) matches parse_another_spell_cast_this_turn's minimum: 2 convention — at resolution time the currently-resolving spell is already in the cast history, so "another" means at least 2 total.
• The existing \"this spell was cast from X\" handler now accepts an optional \" and {recognised condition}\" tail and returns AbilityCondition::And. Partial recognition (zone-half OK, second-half unknown) is rejected on purpose — running with only half the gate is unsafe.

Splitter guard: Otherwise, X and Y stays together

Bare-and split suppressed when the chunk starts with otherwise, / otherwise (mirroring starts_prefix_clause). Without it, "Otherwise, put ~ 7th from top and you gain 7 life" splits at the and, the gain-life chunk attaches as a sibling sub_ability of the win effect, and the Otherwise body loses half its content.

Result

Approach now parses to:

WinTheGame
  condition: And { CastFromZone(Hand), SpellsCastThisGame{filter=Named \"approach of the second sun\"} >= 2 }
  else_ability: PutAtLibraryPosition(7th) -> GainLife(7)

• First cast — condition false (only the resolving cast is in history). Otherwise fires: library 7th + gain 7 life.
• Second cast — condition true (2 named-Approaches in history). Win the game.

Test plan

• cargo test -p engine --lib (7146 tests, all green)
• cargo clippy -p engine --all-targets -- -D warnings (clean)
• cargo fmt --check
• Parser regression test (approach_of_the_second_sun_parses_compound_condition_and_otherwise_branch) asserts the full parsed shape and the literal FilterProp::Named { name: \"approach of the second sun\" } value — fed un-tilde'd "named X" text the way normalize_card_name_refs' "named ~" → "named CardName" restore produces in production.
• Resolver test (resolve_quantity_spells_cast_this_game_filtered_by_name) exercises the runtime against spells_cast_this_game_by_player.
• End-to-end pipeline test (approach_of_the_second_sun_round_trips_through_record_spell_cast) runs the full path: record_spell_cast → SpellCastRecord.name populated → resolve_quantity finds the named-filter count, plus controller-scope isolation against an opponent's same-named casts.
• Card-data regeneration confirms Approach's emitted condition is And { CastFromZone(Hand), SpellsCastThisGame{filter=Named(\"approach of the second sun\")} >= 2 }.

🤖 Generated with Claude Code

[matthewevans]

/gemini review

[gemini-code-assist]

Code Review

This pull request implements game-scope spell cast history tracking and name-filtered counting, primarily to support cards like Approach of the Second Sun. It introduces a name field to SpellCastRecord, adds spells_cast_this_game_by_player to the GameState, and extends the parser to handle "you've cast another spell named {LITERAL} this game" conditions. My feedback focuses on several architectural violations: the use of .starts_with() for parsing dispatch (violating R1), the use of standard Vec instead of im::Vector for a hot GameState field (violating R7), and two instances where SpellCastRecord is initialized with an empty name in casting logic, which would break name-filtered restrictions.