Repository navigation
fix(conn): honor backslash escapes in E'' strings when scrubbing - #57
Merged
Merged
Conversation
In an E'...' string `\'` is an escaped quote, but the string-literal regex ended the literal there, so the rest of it survived scrubbing: E'it\'s … jane.doe' became E'?'s … jane.doe'. The regex now matches E'...' (case-insensitive E at a word boundary) with backslash escapes before falling back to standard '...' literals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Found while fixing #54. In an
E'...'string\'is an escaped quote, but theliteral regex ended the string there, so the rest leaked:
The regex now matches
E'...'with backslash escapes before falling back tostandard
'...'. Independent of #56 (different lines); either can land first.Verification
main, pass here (escaped quote, escaped backslash, mixed''/\', plain literals,CASE … THEN 'x'stays a plain literal).scripts/gate.shgreen.Checklist
scripts/gate.shpassesmodel.Context/--json/ the store — this closes a hole