Skip to content

ci: remove stray codeql.yml workflow - #111

Closed
don-petry wants to merge 16 commits into
mainfrom
claude/issue-93-20260418-1841
Closed

ci: remove stray codeql.yml workflow#111
don-petry wants to merge 16 commits into
mainfrom
claude/issue-93-20260418-1841

Conversation

@don-petry

Copy link
Copy Markdown
Contributor

Summary

  • Deletes .github/workflows/codeql.yml which was identified as drift by the weekly compliance audit
  • The org now uses GitHub-managed CodeQL default setup; per-repo workflow files run duplicate analysis alongside the managed default setup

Standard Reference

standards/ci-standards.md#2-codeql-analysis-github-managed-default-setup

Closes #93

Generated with Claude Code

Copilot AI review requested due to automatic review settings April 18, 2026 18:42
@coderabbitai

coderabbitai Bot commented Apr 18, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@don-petry, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 57 minutes and 50 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: cffdcc40-40c1-48c5-ac6d-d6553a69cb49

📥 Commits

Reviewing files that changed from the base of the PR and between d8da2d2 and c29f2ce.

📒 Files selected for processing (1)
  • .gitignore
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/issue-93-20260418-1841

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the repository-local CodeQL GitHub Actions workflow to align with the org standard of using GitHub-managed CodeQL default setup (avoiding duplicate CodeQL runs and compliance drift).

Changes:

  • Delete .github/workflows/codeql.yml (legacy CodeQL workflow).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@don-petry

don-petry commented Apr 19, 2026

Copy link
Copy Markdown
Contributor Author
Superseded by automated re-review at a75497102197bbf379a3a9896375eb9fd53f1aa5 — click to expand prior review.

Automated review — APPROVED

Risk: MEDIUM
Reviewed commit: c19441266294dd5fb948f74cd31cbd804990b024
Cascade: triage → deep (see triage: haiku 4.5 → deep: sonnet 4.6 + duck: gpt-5.4 → audit: opus 4.6 for models)

Summary

PR removes a per-repo CodeQL workflow that a weekly compliance audit flagged as drift; the org now uses GitHub-managed CodeQL default setup which continues to run successfully (evidenced by the passing CodeQL check in the status rollup). All CI checks pass, the change is a pure deletion with no logic changes, and the PR clearly addresses the linked compliance issue #93.

Findings

Info

  • [info] .github/workflows/codeql.yml — Workflow deletion removes a properly-pinned, minimal-permission CodeQL config (SHA-pinned actions, permissions: {}, only security-events: write + contents: read). No regression risk: GitHub-managed CodeQL default setup confirmed active via passing 'CodeQL' and 'Analyze (actions)' checks in CI rollup.
  • [info] Triage escalated due to 'triage-output-invalid' (system failure in the triage tier), not due to content signals in the PR itself. Deep review finds no substantive security or correctness concerns.

CI status

All CI checks pass. CodeQL continues to run via GitHub-managed default setup.


Reviewed by the don-petry PR-review cascade (triage: haiku 4.5 → deep: sonnet 4.6 + duck: gpt-5.4 → audit: opus 4.6). Reply with @don-petry if you need a human.

@don-petry
don-petry enabled auto-merge (squash) April 19, 2026 16:50
@github-actions

Copy link
Copy Markdown
Contributor

Auto-rebase failed — merge conflict — this branch has conflicts with main that must be resolved manually.

Please resolve the conflicts and push:

git fetch origin
git merge origin/main
# resolve conflicts, then:
git add .
git commit
git push

@petry-projects-pr-review-agent petry-projects-pr-review-agent Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed by the don-petry PR-review cascade (triage: haiku 4.5 → deep: sonnet 4.6 + duck: gpt-5.4 → audit: opus 4.6). Reply with @don-petry if you need a human.

@petry-projects-pr-review-agent petry-projects-pr-review-agent Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed by the don-petry PR-review cascade (triage: haiku 4.5 → deep: sonnet 4.6 + duck: gpt-5.4 → audit: opus 4.6). Reply with @don-petry if you need a human.

@donpetry-bot donpetry-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed by the don-petry PR-review cascade (triage: haiku 4.5 → deep: sonnet 4.6 + duck: gpt-5.4 → audit: opus 4.6). Reply with @don-petry if you need a human.

The org now uses GitHub-managed CodeQL default setup. Per-repo
workflow files are drift and run duplicate analysis alongside
the managed default setup.

Closes #93

Co-authored-by: don-petry <don-petry@users.noreply.github.com>
@don-petry
don-petry force-pushed the claude/issue-93-20260418-1841 branch from c194412 to a7190c6 Compare May 13, 2026 17:08
@don-petry
don-petry requested a review from a team as a code owner May 13, 2026 17:08
@sonarqubecloud

Copy link
Copy Markdown

@don-petry

Copy link
Copy Markdown
Contributor Author

Auto-rebase failed — merge conflict — this branch has conflicts with main that must be resolved.

dev-lead will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention.

To resolve manually instead:

git fetch origin
git merge origin/main
# resolve conflicts, then:
git add .
git commit
git push

@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — review-changes (applied)

Changes committed and pushed.

auto-merge was automatically disabled May 25, 2026 20:01

Pull Request is not mergeable

@sonarqubecloud

Copy link
Copy Markdown

@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — review-changes (applied)

Changes committed and pushed.

@don-petry
don-petry enabled auto-merge (squash) May 25, 2026 20:03
@don-petry

Copy link
Copy Markdown
Contributor Author

Auto-rebase failed — merge conflict — this branch has conflicts with main that must be resolved.

dev-lead will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention.

To resolve manually instead:

git fetch origin
git merge origin/main
# resolve conflicts, then:
git add .
git commit
git push

@don-petry

Copy link
Copy Markdown
Contributor Author

Auto-rebase failed — merge conflict — this branch has conflicts with main that must be resolved.

dev-lead will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention.

To resolve manually instead:

git fetch origin
git merge origin/main
# resolve conflicts, then:
git add .
git commit
git push

@donpetry-bot

Copy link
Copy Markdown
Contributor

Automated review — human attention needed

This PR has been through 3 automated review cycles (cap: 3) without converging on an approval-and-merge state. Further automated review has been paused to avoid infinite loops.

Please take a look manually, or close this PR if it's no longer needed. Once a human review resolves the situation, remove the needs-human-review label and the cascade can be re-engaged on the next push.

Posted by the donpetry-bot PR-review cascade.

@donpetry-bot
donpetry-bot requested a review from a team May 30, 2026 20:38
@don-petry

Copy link
Copy Markdown
Contributor Author

Auto-rebase failed — merge conflict — this branch has conflicts with main that must be resolved.

dev-lead will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention.

To resolve manually instead:

git fetch origin
git merge origin/main
# resolve conflicts, then:
git add .
git commit
git push

@don-petry

Copy link
Copy Markdown
Contributor Author

Auto-rebase failed — merge conflict — this branch has conflicts with main that must be resolved.

dev-lead will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention.

To resolve manually instead:

git fetch origin
git merge origin/main
# resolve conflicts, then:
git add .
git commit
git push

@don-petry

Copy link
Copy Markdown
Contributor Author

Closing due to merge conflict that cannot be auto-rebased. Re-implementing from fresh main via dev-lead.

@don-petry don-petry closed this Jun 2, 2026
auto-merge was automatically disabled June 2, 2026 12:19

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compliance: stray-codeql-workflow

3 participants