Skip to content

fix: add org baseline secret patterns to .gitignore - #191

Closed
don-petry wants to merge 3 commits into
mainfrom
claude/issue-172-20260414-1146
Closed

don-petry wants to merge 3 commits into
mainfrom
claude/issue-172-20260414-1146

Conversation

@don-petry

Copy link
Copy Markdown
Collaborator

Summary

  • Copies the petry-projects org baseline .gitignore (secrets-only) verbatim into the repo
  • Adds the missing *.pem and *.key patterns (and all other baseline secret patterns) required by the push-protection standard
  • Preserves existing repo-specific ignores (node_modules/, coverage/, test-results/, playwright-report/) in a dedicated section at the top

Closes #172

Generated with Claude Code

Copies the petry-projects org baseline .gitignore (secrets-only) into
the repo, adding the missing *.pem, *.key, and all other baseline
secret patterns required by the push-protection standard.

Closes #172

Co-authored-by: don-petry <don-petry@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 14, 2026 11:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@coderabbitai

coderabbitai Bot commented Apr 14, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@github-actions[bot] has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 55 minutes and 53 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 55 minutes and 53 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e819ddce-9430-481e-847c-8bbc754972f5

📥 Commits

Reviewing files that changed from the base of the PR and between 56ee75a and bbd1c65.

📒 Files selected for processing (1)
  • .gitignore
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/issue-172-20260414-1146

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@don-petry

Copy link
Copy Markdown
Collaborator Author

Hey @don-petry — this PR is ready for review and merge. It brings the repo into compliance with the push-protection standard by copying the org-baseline .gitignore verbatim and adding the missing *.pem / *.key patterns (plus the full set of baseline secret patterns).

@sonarqubecloud

Copy link
Copy Markdown

@don-petry

Copy link
Copy Markdown
Collaborator Author

Automated review — APPROVED

Risk: LOW
Reviewed commit: c063fdd3240226d4c4b1d886e68b2415e99439f4
Cascade: triage → deep (see triage: haiku 4.5 → deep: sonnet 4.6 + duck: gpt-5.4 → audit: opus 4.6 for models)

Summary

PR #191 adds 394 lines to .gitignore, copying the petry-projects org-baseline secrets-only ignore patterns to bring the repo into compliance with the push-protection standard (closes #172). All CI checks pass (SonarCloud quality gate passed, 0 issues, 0 security hotspots; CodeQL clean; Node.js, Playwright, coverage, and build all green). The change is security-positive — it reduces the risk of accidentally committing credential files — and carries no executable code or logic changes.

Findings

Info

  • .gitignore.npmrc, secrets.yaml/yml, and *.bak are broad patterns that could block legitimate non-secret files. The PR acknowledges this and provides per-repo negation guidance; acceptable under the org baseline approach.
  • Triage escalated due to triage-output-invalid (triage tier produced no parseable JSON); there were no substantive security signals identified by triage.
  • mergeStateStatus is BLOCKED / reviewDecision is REVIEW_REQUIRED — a human approval is still needed to merge.

CI status

All CI checks green: SonarCloud quality gate passed (0 issues, 0 security hotspots), CodeQL clean, Node.js, Playwright, coverage, and build all passed.


Reviewed by the don-petry PR-review cascade (triage: haiku 4.5 → deep: sonnet 4.6 + duck: gpt-5.4 → audit: opus 4.6). Reply with @don-petry if you need a human.

@don-petry
don-petry enabled auto-merge (squash) April 16, 2026 21:37

@petry-projects-pr-review-agent petry-projects-pr-review-agent Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed by the don-petry PR-review cascade (triage: haiku 4.5 → deep: sonnet 4.6 + duck: gpt-5.4 → audit: opus 4.6). Reply with @don-petry if you need a human.

@petry-projects-pr-review-agent petry-projects-pr-review-agent Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed by the don-petry PR-review cascade (triage: haiku 4.5 → deep: sonnet 4.6 + duck: gpt-5.4 → audit: opus 4.6). Reply with @don-petry if you need a human.

@don-petry

Copy link
Copy Markdown
Collaborator Author

Closing as duplicate of #212 — same fix for issue #191. The newest attempt is kept open.

@don-petry don-petry closed this May 3, 2026
auto-merge was automatically disabled May 3, 2026 15:01

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compliance: gitignore_secrets_block

2 participants