Skip to content

security: add gitleaks secret-scan CI job and expand .gitignore to org baseline #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
don-petry wants to merge 3 commits into from
Closed

security: add gitleaks secret-scan CI job and expand .gitignore to org baseline #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
22ad823
security: add gitleaks secret-scan CI job and expand .gitignore to or…
github-actions[bot] Apr 14, 2026
b1aec59
Merge branch 'main' into claude/issue-170-20260414-1141
github-actions[bot] Apr 21, 2026
21482d7
Merge branch 'main' into claude/issue-170-20260414-1141
github-actions[bot] Apr 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,3 +101,28 @@ jobs:

- name: Verify no remaining issues after auto-fix
run: npm run check

secret-scan:
name: Secret scan (gitleaks)
runs-on: ubuntu-latest
permissions:
contents: read
security-events: write

steps:
- name: Checkout (full history)
# Pin to SHA per Action Pinning Policy (ci-standards.md#action-pinning-policy).
# Look up current SHA: gh api repos/actions/checkout/git/refs/tags/v4 --jq '.object.sha'
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
Comment on lines +115 to +116

Copilot AI Apr 14, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The checkout pinning comment is internally inconsistent: it instructs looking up the SHA for the v4 tag, but the pinned SHA is annotated as v6.0.2 (and elsewhere in this repo the same SHA is labeled # v6). Please update the lookup command and the trailing version comment so they reference the same tag/major version as the SHA you intend to pin; otherwise future updates are more likely to pin the wrong ref.

Suggested change
# Look up current SHA: gh api repos/actions/checkout/git/refs/tags/v4 --jq '.object.sha'
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
# Look up current SHA: gh api repos/actions/checkout/git/refs/tags/v6 --jq '.object.sha'
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6

Copilot uses AI. Check for mistakes.
with:
fetch-depth: 0

- name: Run gitleaks
# Pinned to SHA per Action Pinning Policy (ci-standards.md#action-pinning-policy).
# Refresh with: gh api repos/gitleaks/gitleaks-action/git/refs/tags/v2 --jq '.object.sha'
# then dereference if it points at an annotated tag.
uses: gitleaks/gitleaks-action@ff98106e4c7b2bc287b24eaf42907196329070c7 # v2.3.9
with:
args: detect --source . --redact --verbose --exit-code 1
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Loading
Loading