Compliance: stub-surface-drift-feature-ideation.yml-on

[don-petry]

Compliance Finding

Category: ci-workflows
Severity: error
Check: stub-surface-drift-feature-ideation.yml-on

Detail

The feature-ideation.yml caller stub's on: surface has drifted from the canonical standards/workflows/feature-ideation.yml. These stubs are thin callers — the on: triggers, permissions: grants, and concurrency: block are owned centrally and are not repo-adjustable (only the documented with: inputs and the tier channel pin may differ per repo). Re-sync on: from standards/workflows/feature-ideation.yml.

Standard Reference

standards/ci-standards.md#centralization-tiers

Remediation

Copy the relevant workflow template from standards/workflows/ verbatim — do not generate from scratch:

gh api repos/petry-projects/.github/contents/standards/workflows/<template>.yml --jq '.content' | base64 -d > .github/workflows/<template>.yml

Available templates: agent-shield.yml, dev-lead.yml, dependabot-automerge.yml, dependabot-rebase.yml, dependency-audit.yml, feature-ideation.yml

---

This issue was automatically created by the weekly compliance audit.

[don-petry]

Dev-Lead Implementation Plan

Issue: #449 — Compliance: stub-surface-drift-feature-ideation.yml-on

Scope

Re-sync the on: trigger surface of .github/workflows/feature-ideation.yml with the canonical standards/workflows/feature-ideation.yml — the centrally-owned on: block is the only surface flagged by this check.

Root cause

The canonical on.workflow_dispatch.inputs defines two inputs that the local stub is missing:

• enhance_backlog (boolean) — backlog enhancement sweep
• target_discussion (string) — internal redispatch bridge input

The schedule, discussion, and the existing focus_area / research_depth / dry_run inputs are already in sync.

Implementation Checklist

• Add the enhance_backlog input to on.workflow_dispatch.inputs verbatim from canonical
• Add the target_discussion input to on.workflow_dispatch.inputs verbatim from canonical
• Leave permissions:, concurrency:, and the jobs: body untouched (not part of the -on surface check; scope-limited per issue)

Tests to Write

No test harness exists for workflow YAML in this repo (GAS Jest suite only). Per the Phase 2 documentation/configuration exception, no unit test is added; correctness is verified by a byte-for-byte match of the on: block against the canonical template plus actionlint/YAML parse.

Test Command

npm test (unaffected suite) + .dev-lead/scripts/dev-lead-lint.sh + YAML validation

[don-petry]

Dev-Lead: Implementation Complete

Plan Execution

• Diagnosed the on: drift: canonical standards/workflows/feature-ideation.yml defines two workflow_dispatch inputs the local stub was missing — enhance_backlog (boolean) and target_discussion (string)
• Added both inputs to on.workflow_dispatch.inputs byte-verbatim from the canonical template
• Left permissions:, concurrency:, and the jobs: body untouched — those are separate surfaces (this issue is scoped to -on only)
• Verified against the real audit logic (check_stub_surface_drift / stub_normalize_surface from petry-projects/.github): on: surface now reports CLEAN

Reconciling verbatim-canonical with the mandatory prettier check

The canonical enhance_backlog description is single-quoted with a doubled-quote YAML escape ('…repo''s…'). This repo's mandatory prettier --check . (.prettierrc singleQuote: true) rewrites it to double quotes to avoid the escape, which would re-introduce on: drift on the weekly audit. Since the compliance normalizer strips whole-line comments before comparison, a scoped # prettier-ignore directive keeps the line byte-verbatim with canonical and lets prettier --check pass — satisfying both constraints. No .prettierignore policy change was needed.

Test Results

Test Suites: 12 passed, 12 total
Tests:       301 passed, 301 total
Snapshots:   0 total
Time:        4.795 s

npm run check        → exit 0 (prettier --check clean; eslint 0 errors, only pre-existing warnings)
.dev-lead/scripts/dev-lead-lint.sh → all checks passed
YAML parse           → valid
on: surface vs canonical → CLEAN (drift resolved)

Files Changed

• .github/workflows/feature-ideation.yml: added the enhance_backlog and target_discussion workflow_dispatch inputs to the on: block, verbatim from the canonical template, re-syncing the drifted trigger surface. Added a scoped # prettier-ignore (with a WHY comment) so prettier does not rewrite the canonical single-quote escape.

Notes

• TDD exception (Phase 2): this is a CI-workflow configuration change; the repo has no test harness for workflow YAML (Jest suite covers GAS logic only). Correctness is verified by reproducing the actual compliance drift algorithm and by YAML/prettier/lint validation.
• Scope discipline: the canonical's fuller jobs: body (the redispatch/prep restructure) and its extra job-level permissions: {} blocks would satisfy a separate -permissions / -jobs check but are out of scope for this -on finding, so they were intentionally left unchanged.

[don-petry]

Dev-Lead Implementation Plan

Issue: #449 — Compliance: stub-surface-drift-feature-ideation.yml-on

Scope

Re-sync the on: trigger surface of .github/workflows/feature-ideation.yml from the canonical standards/workflows/feature-ideation.yml, restoring the centrally-owned trigger shape while preserving the documented per-repo customizations.

Analysis

Fetched the canonical template and diffed. Within the on: block, the only drift is line 68 — the workflow_dispatch.inputs.enhance_backlog.description string is written with double-quote wrapping locally but the canonical uses single-quote wrapping with an escaped apostrophe (repo''s). Semantically identical YAML, but the surface string differs. This is the only in-scope change for check stub-surface-drift-feature-ideation.yml-on.

Out-of-scope diffs (intentionally left unchanged — not part of the on: surface and permitted to differ per repo):

• Lines 110/118: GH_PAT_DON_PETRY || GH_PAT_WORKFLOWS override in the redispatch job body (not a trigger).
• Line 185: @feature-ideation/stable channel pin — the tier channel pin, explicitly repo-adjustable.
• Lines 198-210: project_context — a documented with: input, customized for this repo.

Implementation Checklist

• .github/workflows/feature-ideation.yml — re-sync the enhance_backlog input description in the on.workflow_dispatch.inputs block to match canonical quoting

Tests to Write

• None. Pure configuration re-sync with no observable behavioral change (semantically-identical YAML string). No tests cover the workflow trigger surface. Phase 2 TDD exception applies.

Test Command

npm test (full suite, for regression safety) + bash .dev-lead/scripts/dev-lead-lint.sh

[don-petry]

Dev-Lead: Implementation Complete

Plan Execution

• Fetched canonical standards/workflows/feature-ideation.yml and diffed against the repo stub
• Re-synced the on: surface — the sole in-scope drift was the enhance_backlog input description quoting (line 68). The on: block is now byte-identical to canonical
• Preserved all out-of-scope, repo-permitted customizations (see Notes)
• Added .github/workflows/feature-ideation.yml to .prettierignore to prevent Prettier from re-introducing the drift (root-cause fix)
• bash .dev-lead/scripts/dev-lead-lint.sh — passed
• npm run check (prettier --check + eslint) — passed (0 errors)
• npm test — 301/301 passed
• Verified YAML parses and the escaped apostrophe decodes to an identical value

Test Results

> jest --runInBand

Test Suites: 12 passed, 12 total
Tests:       301 passed, 301 total
Snapshots:   0 total
Time:        4.82 s
Ran all test suites.

dev-lead-lint: all checks passed
npm run check: exit 0 (prettier clean; 22 pre-existing eslint warnings, 0 errors)

Files Changed

• .github/workflows/feature-ideation.yml: re-synced the on.workflow_dispatch.inputs.enhance_backlog.description scalar from double-quote form to the canonical single-quote (''-escaped) form, making the on: surface byte-identical to the standard. Semantically identical YAML — no behavioral change.
• .prettierignore: added .github/workflows/feature-ideation.yml, alongside the existing dev-lead.yml and initiative-driver.yml entries. Prettier's double-quote preference was the root cause of the drift (it rewrites the canonical single-quoted scalars) and would re-corrupt the on: surface on the next prettier --write ., re-triggering this finding.

Notes

Scope was limited to the on: surface per check stub-surface-drift-feature-ideation.yml-on. Three other diffs vs. canonical were intentionally left untouched because they are outside the on: surface and are explicitly repo-adjustable:

• redispatch job: GH_PAT_DON_PETRY || GH_PAT_WORKFLOWS token override (job body, not a trigger)
• uses: line: @feature-ideation/stable channel pin (the tier channel pin, per the issue)
• project_context: — a documented per-repo with: input

No tests were added: this is a byte-surface config re-sync with no observable behavioral change (verified: the escaped scalar decodes to an identical string), so the Phase 2 TDD exception applies.