SonarCloud modernization (1/3): src/ app code

[don-petry]

Split from #421 (×68 modernization epic) — story 1 of 3. Behavior-preserving SonarCloud idiom modernizations across the core src/ app code. No new tests (Phase-2 TDD exception); existing Jest suite + npm run check are the regression guard.

Files & fixes

• src/gas-utils.js — node:crypto, String#replaceAll, TypeError, super-linear regex simplification (S8786)
• src/gmail-to-drive-by-labels/src/index.js — Date.now(), char-class dedupe [\w-], conditional-default ||, toSorted
• src/calendar-to-briefing-doc/src/index.js — optional chaining / misc idioms
• src/calendar-to-sheets/src/index.js — toSorted, char-class / misc idioms
• src/deploy/index.js — idiom fix

Test command

npm test (Jest + coverage) and npm run check (prettier + eslint). .gs files intentionally untouched.

Parent: #421 · Epic: #440

[don-petry]

Dev-Lead Implementation Plan

Issue: #442 — SonarCloud modernization (1/3): src/ app code

Scope

Behavior-preserving SonarCloud idiom modernizations across core src/ app code — no new tests (Phase-2 TDD exception for behavior-preserving refactors); existing Jest suite (301 tests) + npm run check are the regression guard.

Implementation Checklist

• src/gas-utils.js — require('node:crypto'); String#replaceAll; throw new TypeError; simplify super-linear reply-header regexes (negated char classes / bounded quantifiers)
• src/gmail-to-drive-by-labels/src/index.js — new Date().getTime() → Date.now(); char-class dedupe [\w\d_-] → [\w-]; subject ? subject : '(No Subject)' → subject || '(No Subject)'; .slice().sort() → toSorted()
• src/calendar-to-briefing-doc/src/index.js — optional chaining (items[0] && items[0].event → items[0]?.event); nullish default (x != null ? x : 7 → x ?? 7)
• src/calendar-to-sheets/src/index.js — .sort().forEach() → toSorted().forEach(); char-class dash-escape idiom
• src/deploy/index.js — find(...) || null → find(...) ?? null

Tests to Write

• None — behavior-preserving refactor. Existing suite is the guard (Phase-2 TDD exception per issue).

Test Command

npm test (Jest + coverage) and npm run check (prettier + eslint)

[don-petry]

Dev-Lead: Implementation Complete

Plan Execution

• src/gas-utils.js — node:crypto, String#replaceAll, TypeError, super-linear reply-header regex simplification
• src/gmail-to-drive-by-labels/src/index.js — Date.now(), [\w-] char-class dedupe, || conditional-default, toSorted
• src/calendar-to-briefing-doc/src/index.js — optional chaining, ?? nullish default
• src/calendar-to-sheets/src/index.js — toSorted, char-class dash-escape idiom
• src/deploy/index.js — ?? null idiom fix

Test Results

Test Suites: 12 passed, 12 total
Tests:       301 passed, 301 total

npm run check: 0 errors (22 pre-existing unused-var warnings, unchanged from baseline)

node scripts/check-coverage.js:
  ✅ statements  98.91% [req 95%]
  ✅ branches    89.98% [req 85%]
  ✅ functions   98.00% [req 95%]
  ✅ lines       100%   [req 100%]

.dev-lead/scripts/dev-lead-lint.sh: all checks passed

Files Changed

• src/gas-utils.js: require('crypto') → require('node:crypto'); .replace(/\n{2,}/g, …) → .replaceAll(…); throw new Error → throw new TypeError for unsupported blob type; three reply-header regexes rewritten to remove adjacent .+\s+ / .+<.+@.+> ambiguity (bounded \s and negated char classes) to eliminate super-linear backtracking.
• src/gmail-to-drive-by-labels/src/index.js: new Date().getTime() → Date.now() (×2); [\w\d_-] → [\w-] (×3, identical char set); subject ? subject : '(No Subject)' → subject || '(No Subject)' (×2); arr.slice().sort() → arr.toSorted() (×2).
• src/calendar-to-briefing-doc/src/index.js: items[0] && items[0].event → items[0]?.event; config.scheduleHour != null ? config.scheduleHour : 7 → config.scheduleHour ?? 7.
• src/calendar-to-sheets/src/index.js: toDelete.sort().forEach() → toDelete.toSorted().forEach(); [=+\-@] → [=+@-] (dash at end, no escape; identical char set).
• src/deploy/index.js: find(...) || null → find(...) ?? null.
• src/gmail-to-drive-by-labels/tests/code.test.js: updated the timeout-simulation Date mock to also stub the static Date.now() (the code now calls Date.now() instead of new Date().getTime()). No test expectations changed — only the mock's time hook.

Notes

• All changes are behavior-preserving on realistic inputs; the existing Jest suite + npm run check are the regression guard (Phase-2 TDD skipped per the issue's behavior-preserving refactor exception).
• .gs files intentionally untouched.
• The one test edit is a mock-infrastructure update (hook Date.now()), required because the Date.now() modernization is equivalent in production but bypasses the old instance-getTime() stub; assertions are unchanged.
• Regex note: the reply-header simplifications preserve matching for all realistic email headers and all existing test cases; they only diverge on adversarial multi-newline inputs that never occur in reply headers — this is the intended effect of removing the super-linear (ReDoS-prone) backtracking.

[don-petry]

Dev-Lead Implementation Plan

Issue: #442 — SonarCloud modernization (1/3): src/ app code

Scope

Behavior-preserving SonarCloud idiom modernizations across core src/ app code (no .gs changes, no new tests — existing Jest suite + npm run check are the regression guard, per Phase-2 TDD exception for behavior-preserving refactors).

Implementation Checklist

• src/gas-utils.js — require('crypto') → require('node:crypto'); .replace(/\n{2,}/g,'\n') → .replaceAll(...); new Error('Unsupported blob type') → new TypeError(...); simplify super-linear header regexes (\s+.+\s+ → \s.+\s) (S8786)
• src/gmail-to-drive-by-labels/src/index.js — new Date().getTime() → Date.now(); char-class [\w\d_-] → [\w-]; subject ? subject : '(No Subject)' → subject || '(No Subject)'; .slice().sort() → .toSorted()
• src/calendar-to-briefing-doc/src/index.js — optional chaining (items[0] && items[0].event → items[0]?.event); nullish coalescing (x != null ? x : d → x ?? d)
• src/calendar-to-sheets/src/index.js — .sort().forEach() → .toSorted().forEach(); misc idioms
• src/deploy/index.js — .find(...) || null → .find(...) ?? null

Tests to Write

• None — behavior-preserving refactor (Phase-2 TDD exception). Existing 301-test Jest suite is the regression guard.

Test Command

npm test (Jest + coverage) and npm run check (prettier + eslint)

[don-petry]

Dev-Lead: Implementation Complete

Plan Execution

• src/gas-utils.js — node:crypto, replaceAll, TypeError, super-linear header-regex simplification
• src/gmail-to-drive-by-labels/src/index.js — Date.now(), [\w-], || default, toSorted
• src/calendar-to-briefing-doc/src/index.js — optional chaining + nullish coalescing
• src/calendar-to-sheets/src/index.js — toSorted
• src/deploy/index.js — ?? null
• Verify: npm test, coverage, npm run check, dev-lead lint — all green

Test Results

Test Suites: 12 passed, 12 total
Tests:       301 passed, 301 total

Coverage (scripts/check-coverage.js):
  statements  98.91% (>=95%)   branches  89.95% (>=85%)
  functions   98.00% (>=95%)   lines     100%    (>=100%)

npm run check  -> exit 0 (0 errors; only pre-existing unused-var warnings in untouched test files)
dev-lead-lint  -> exit 0

Files Changed

• src/gas-utils.js: require('crypto')→require('node:crypto'); .replace(/\n{2,}/g,…)→.replaceAll; new Error→new TypeError for the unsupported-blob guard; simplified two super-linear reply-header regexes (\s+.+\s+ → \s.+\s, same match set, no catastrophic backtracking).
• src/gmail-to-drive-by-labels/src/index.js: new Date().getTime()→Date.now() (×2); [\w\d_-]→[\w-] (×3, \w already covers \d/_); subject ? subject : '(No Subject)'→subject || '(No Subject)' (×2); .slice().sort()→.toSorted() (×2).
• src/calendar-to-briefing-doc/src/index.js: optional chaining (item && item.event→item?.event, items[0] && items[0].event→items[0]?.event); nullish coalescing (x != null ? x : 7→x ?? 7).
• src/calendar-to-sheets/src/index.js: .sort().forEach()→.toSorted().forEach().
• src/deploy/index.js: .find(...) || null→.find(...) ?? null.
• src/gmail-to-drive-by-labels/tests/code.test.js: the timeout-simulation Date mock stubbed new Date().getTime(); since rebuildDoc was modernized to Date.now(), the mock now also stubs the static Date.now() via a shared helper. No assertions were changed — only the mocking mechanism was updated to track the equivalent modern API.

Notes

• All changes are behavior-preserving idiom modernizations; verified against the full existing suite (Phase-2 TDD exception, no new tests).
• .gs files intentionally untouched.
• calendar-to-sheets: applied toSorted; no genuine char-class dedupe existed in that file (its only char classes — [\x00-\x20], [=+\-@] — have no redundant members, and the \- escape is required to avoid an unintended range), so no further char-class change was made.