Compliance: non-stub-feature-ideation.yml

Compliance Finding

Category: ci-workflows
Severity: error
Check: non-stub-feature-ideation.yml

Detail

Centralized workflow feature-ideation.yml references the reusable but is not pinned to @v1 (org standard). Replace with the canonical stub from standards/workflows/feature-ideation.yml which delegates to petry-projects/.github/.github/workflows/feature-ideation-reusable.yml@v1.

Standard Reference

standards/ci-standards.md#centralization-tiers

Remediation

Please review the linked standard and bring this repository into compliance.

See the full standards documentation for implementation guidance.

This issue was automatically created by the weekly compliance audit.

Dev-Lead Implementation Plan

Issue: #329 — Compliance: non-stub-feature-ideation.yml

Scope

Change .github/workflows/feature-ideation.yml so the uses: line references the reusable workflow pinned to @v1 (the org-standard tag) instead of the SHA hash @ee22b427cbce9ecadcf2b436acb57c3adf0cb63d # v1.

Root Cause

The org compliance check (check_centralized_workflow_stubs in scripts/compliance-audit.sh) expects an exact match for:

uses: petry-projects/.github/.github/workflows/feature-ideation-reusable.yml@v1

The current file uses a SHA hash instead of the v1 tag, so the regex does not match and the finding is raised. The v1 tag exists in petry-projects/.github and resolves to the same commit as the SHA.

Implementation Checklist

.github/workflows/feature-ideation.yml — change uses: from SHA-pinned @ee22b427cbce9ecadcf2b436acb57c3adf0cb63d # v1 to tag-pinned @v1

Tests to Write

None — this is a pure CI configuration change with no observable behavioral change. TDD phase is skipped per the exception rule in AGENTS.md.

Test Command

npm test (no JS logic changed; this is a workflow YAML-only fix)

Dev-Lead: Implementation Complete

Plan Execution

.github/workflows/feature-ideation.yml — changed uses: from SHA-pinned @ee22b427cbce9ecadcf2b436acb57c3adf0cb63d # v1 to tag-pinned @v1
TDD exception noted: pure CI configuration change, no observable behavioral difference
Full test suite passed (301 tests)
Prettier check passed on changed file

Test Results

Test Suites: 12 passed, 12 total
Tests:       301 passed, 301 total
Snapshots:   0 total
Time:        4.56 s
Ran all test suites.

Files Changed

.github/workflows/feature-ideation.yml: Changed uses: pin from @ee22b427cbce9ecadcf2b436acb57c3adf0cb63d # v1 to @v1 on line 91. The v1 tag exists in petry-projects/.github and resolves to the same commit as the SHA, so behaviour is unchanged.

Notes

The compliance check (check_centralized_workflow_stubs in scripts/compliance-audit.sh) regex-matches for the literal tag @v1; the SHA hash form did not satisfy the pattern even though both reference the same commit.
ci-failure-analyst.yml has a pre-existing prettier warning unrelated to this change — not introduced by this PR.

Weekly Compliance Audit (2026-05-29)

This finding is still open.

Detail: Centralized workflow feature-ideation.yml references the reusable but is not pinned to @v1 (org standard). Replace with the canonical stub from standards/workflows/feature-ideation.yml which delegates to petry-projects/.github/.github/workflows/feature-ideation-reusable.yml@v1.

Standard: standards/ci-standards.md#centralization-tiers

Already working on this: an open PR exists for issue #329.

Weekly Compliance Audit (2026-05-30)

This finding is still open.

Detail: Centralized workflow feature-ideation.yml references the reusable but is not pinned to @v1 (org standard). Replace with the canonical stub from standards/workflows/feature-ideation.yml which delegates to petry-projects/.github/.github/workflows/feature-ideation-reusable.yml@v1.

Standard: standards/ci-standards.md#centralization-tiers

@don-petry-dev-lead

Dev-Lead Implementation Plan

Issue: #329 — Compliance: non-stub-feature-ideation.yml

Scope

Replace the commit-hash ref (@ee22b427cbce9ecadcf2b436acb57c3adf0cb63d) in .github/workflows/feature-ideation.yml with the org-standard @v1 tag on the uses: line.

Implementation Checklist

.github/workflows/feature-ideation.yml: Change uses: ref from commit hash to @v1

Tests to Write

N/A — this is a pure CI configuration change with no behavioral impact on the repo's test suite. TDD phase is skipped per the exception clause for behavior-preserving configuration fixes.

Test Command

npm test

Weekly Compliance Audit (2026-06-05)

This finding is still open.

Detail: Centralized workflow feature-ideation.yml references the reusable but is not pinned to @v1 (org standard). Replace with the canonical stub from standards/workflows/feature-ideation.yml which delegates to petry-projects/.github/.github/workflows/feature-ideation-reusable.yml@v1.

Standard: standards/ci-standards.md#centralization-tiers

Weekly Compliance Audit (2026-06-19)

This finding is still open.

Detail: Centralized workflow feature-ideation.yml references the reusable but is not pinned to @v1 (org standard). Replace with the canonical stub from standards/workflows/feature-ideation.yml which delegates to petry-projects/.github/.github/workflows/feature-ideation-reusable.yml@v1.

Standard: standards/ci-standards.md#centralization-tiers

Weekly Compliance Audit (2026-06-26)

This finding is still open.

Detail: Centralized workflow feature-ideation.yml references the reusable but is not pinned to @v1 (org standard). Replace with the canonical stub from standards/workflows/feature-ideation.yml which delegates to petry-projects/.github/.github/workflows/feature-ideation-reusable.yml@v1.

Standard: standards/ci-standards.md#centralization-tiers

Dev-Lead Implementation Plan

Issue: #329 — Compliance: non-stub-feature-ideation.yml

Scope

Replace .github/workflows/feature-ideation.yml with the canonical thin-caller stub from petry-projects/.github/standards/workflows/feature-ideation.yml, bringing the reusable pin and trigger shape into compliance.

Implementation Checklist

Replace .github/workflows/feature-ideation.yml with the canonical stub content, which:
- Pins the reusable to feature-ideation-reusable.yml@897e4dede3518cdd7273b9dc63e607d0d05cbdda # v1 (repo currently pins the stale @419c90fc… SHA)
- Adds the discussion: types: [created] trigger
- Adds the job-level if: guard for the discussion event
- Adds the target_discussion input
Preserve the per-repo project_context (currently the unmodified TODO placeholder, so no customization to carry over)

Tests to Write

TDD exception: this is a CI-config-only change with no observable behavior testable by the repo's Jest suite (which covers GAS JS logic, not workflow YAML). No workflow-stub tests exist in this repo. Validation is via YAML parse + existing lint/test suite passing.

Test Command

npm test (plus npm run check and bash .dev-lead/scripts/dev-lead-lint.sh)

Dev-Lead: Implementation Complete

Plan Execution

Replaced .github/workflows/feature-ideation.yml with the canonical thin-caller stub from petry-projects/.github/standards/workflows/feature-ideation.yml (fetched authoritatively via gh api)
Updated the reusable pin from the stale @419c90fc… SHA to @897e4dede3518cdd7273b9dc63e607d0d05cbdda # v1
Added the discussion: types: [created] trigger, the job-level if: guard, and the target_discussion input that the canonical stub now carries
Preserved the per-repo project_context (was — and remains — the unmodified TODO placeholder, so no customization lost)
TDD exception applied: CI-config-only change, no behavior testable by the repo's Jest suite (which covers GAS JS logic, not workflow YAML); no workflow-stub tests exist in this repo

Test Results

=== YAML parse ===
YAML OK

=== dev-lead-lint ===
  [lint] shellcheck on 4 file(s)...
  [lint] validating CODEOWNERS...
OK: CODEOWNERS
  [lint] all checks passed

=== prettier --check .github/workflows/feature-ideation.yml ===
All matched files use Prettier code style!

=== npm run check ===  (exit 0 — 22 pre-existing warnings, 0 errors, all in unrelated gmail-to-drive-by-labels tests)

=== npm test ===
Test Suites: 12 passed, 12 total
Tests:       301 passed, 301 total
Snapshots:   0 total
Time:        4.837 s

Files Changed

.github/workflows/feature-ideation.yml: replaced with the canonical org stub — corrects the reusable pin to the # v1 SHA and adds the discussion trigger / if: guard / target_discussion input

Notes

The issue text described the target as @v1; the authoritative canonical stub in the central repo pins to the v1-tagged commit SHA 897e4dede3518cdd7273b9dc63e607d0d05cbdda # v1 (org SHA-pinning convention). This repo's file now matches the canonical stub exactly. No follow-up issues needed.

feat: implement issue #329 — Compliance: non-stub-feature-ideation.yml (

Compliance: non-stub-feature-ideation.yml #329

Description

Compliance Finding

Detail

Standard Reference

Remediation

Activity

don-petry commented on May 26, 2026

Dev-Lead Implementation Plan

Scope

Root Cause

Implementation Checklist

Tests to Write

Test Command

don-petry commented on May 26, 2026

Dev-Lead: Implementation Complete

Plan Execution

Test Results

Files Changed

Notes

don-petry commented on May 29, 2026

don-petry commented on May 30, 2026

don-petry commented on May 30, 2026

don-petry commented on May 30, 2026

don-petry commented on Jun 3, 2026

Dev-Lead Implementation Plan

Scope

Implementation Checklist

Tests to Write

Test Command

don-petry commented on Jun 5, 2026

2 remaining items

don-petry commented on Jun 19, 2026

don-petry commented on Jun 26, 2026

don-petry commented on Jun 26, 2026

Dev-Lead Implementation Plan

Scope

Implementation Checklist

Tests to Write

Test Command

don-petry commented on Jun 26, 2026

Dev-Lead: Implementation Complete

Plan Execution

Test Results

Files Changed

Notes

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions