feat: implement issue #956 — Compliance: ruleset-drift-pr-quality-dismiss_stale_reviews_on_push - #968
Conversation
…miss_stale_reviews_on_push
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing |
|
Warning Review limit reached
Next review available in: 53 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe compliance audit suite now tests that disabling ChangesRuleset drift regression coverage
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
codeant-ai
Bot
added
the
size:XS
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Dev-Lead — waiting on PR blockers (intent: review-changes)PR: #968 |
|
Note @don-petry I reviewed this PR and no code changes were needed, but it still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews), so I cannot mark it done yet. I'll re-check automatically. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@test/scripts/compliance-audit/ruleset-contents-drift.bats`:
- Around line 129-135: Update the test named “disabled
dismiss_stale_reviews_on_push → finding naming expected/actual” to verify the
reported values in addition to the identifier, parameter name, and error status.
Assert that the output includes expected `true` and actual `false`, or parse the
finding JSON and validate both fields.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 5356edda-c4f7-4c19-9852-e6e3739b8b60
📒 Files selected for processing (1)
test/scripts/compliance-audit/ruleset-contents-drift.bats
|
@coderabbitai resolve |
Dev-Lead — fix-reviews (applied)Changes committed and pushed. |
✅ Action performedComments resolved and changes approved. |
|
Dev-Lead — waiting on PR blockers (intent: fix-reviews)PR: #968 |
donpetry-bot
left a comment
donpetry-bot
left a comment
There was a problem hiding this comment.
Automated review — APPROVED ✓
Risk: LOW
Reviewed commit: d5c5f7037673519d25a38c34b0b895b03a3a7efb
Review mode: triage-approved (single reviewer)
Summary
Test-only PR (+11/−0, 1 file) adding a bats regression test to test/scripts/compliance-audit/ruleset-contents-drift.bats. The new test verifies that disabling dismiss_stale_reviews_on_push in the pr-quality ruleset produces a drift finding (ruleset-drift-pr-quality-dismiss_stale_reviews_on_push) at error severity, naming the parameter and the expected (true) vs actual (false) values. It follows the exact pattern of the adjacent per-parameter drift tests and even asserts more (expected/actual values) than its siblings, implementing CodeRabbit's suggestion from the review thread.
Linked issue analysis
Closes #956, a weekly compliance-audit finding that dismiss_stale_reviews_on_push drifted from the codified standard. The PR adds detection/regression coverage for exactly this drift parameter, matching the established dev-lead pattern used for sibling parameters (require_code_owner_review, required_approving_review_count, etc.) in the same file. Note: the operational half of the remediation — running scripts/apply-rulesets.sh --repo petry-projects/.github to converge the live ruleset — is an admin API action that cannot be performed via this PR; an org admin should confirm convergence separately.
Findings
No blocking findings.
- Test-only change; no production script, workflow, or dependency modifications.
- Assertions match the drift checker's real output format (validated by the passing 'Lint and bats' CI job and consistent with the finding text in issue #956).
- The single CodeRabbit review thread (asking to assert expected/actual values) is resolved and its suggestion is implemented in the test; CodeRabbit's latest review is APPROVED.
- Secret scanning MCP tool unavailable in this run; gitleaks CI check passed and the diff contains no secret-like content.
CI status
All required checks green: Lint, Lint and bats, ShellCheck, CodeQL, Agent Security Scan, agent-shield, Secret scan (gitleaks), SonarCloud (quality gate passed), dependency-audit (npm audit passed; other ecosystems skipped), pr-auto-review dispatch. A few dev-lead / dispatch and dev-lead / ci-relay entries show CANCELLED/SKIPPED from superseded runs; the latest dispatch run succeeded. No failing checks.
Reviewed automatically by the PR-review agent (single-reviewer mode: fable 5). Reply if you need a human review.
2 participants
User description
Closes #956
Implemented by dev-lead agent. Please review.
CodeAnt-AI Description
Detect disabled stale-review dismissal in compliance ruleset drift checks
What Changed
Impact
✅ Catches disabled stale-review protection✅ Clearer ruleset drift findings💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.
Summary by CodeRabbit