feat(personas): add address property to persona schema - #753
Conversation
The qa-lead persona (PR #1279 in .github-private) introduces
`address` for @-mention routing. The canonical schema had
additionalProperties:false and no address entry, causing the
validate-personas CI check to reject the new field.
Adds an optional `address` object property with:
- handle (required): org/team-slug — the router resolves it
by stripping the org prefix; slug MUST equal persona id
- aliases (optional): additional team handles (e.g. from renames)
Companion to petry-projects/.github-private#1279.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reached
Next review available in: 40 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
There was a problem hiding this comment.
Code Review
This pull request reformats the persona.schema.json file and introduces a new address property to define how humans can @-mention a persona using GitHub team handles and aliases. The feedback suggests adding "uniqueItems": true to the aliases array definition to prevent duplicate entries.
There was a problem hiding this comment.
Pull request overview
Updates the org’s canonical persona manifest JSON schema to support a new optional address block used for @-mention routing, while keeping existing persona manifests valid.
Changes:
- Add optional
addressobject with requiredhandleand optionalaliasestostandards/personas/persona.schema.json. - Reformat/normalize the schema JSON (expanded arrays/objects; escaped unicode characters) without intended semantic changes to existing constraints.
Dev-Lead — fix-reviews (applied)Changes committed and pushed. |
|
Superseded by #752, which merged at 02:17:14 — five minutes after this PR was opened at 02:12:51. This was auto-created to unblock petry-projects/.github-private#1279's failing Merging this would regress the schema, so closing rather than rebasing:
The loose pattern is specifically the hole Copilot flagged on #752 — it would let |



Summary
addressobject property tostandards/personas/persona.schema.jsonqa-leadpersona (Rename murat → qa-lead and make it @-addressable .github-private#1279) which introduces @-mention routing via a GitHub team handlevalidate-personasCI rejectsqa-lead/persona.ymlwith "Additional properties are not allowed ('address' was unexpected)"Schema addition
addressis optional — existing manifests without it continue to pass validation unchanged.Test plan
validate-personasCI in.github-privatePR #1279 passes once this branch is in place (the validator triesfeat/qa-lead-role-renamebefore falling back tomain)addressstill validate cleanly🤖 Generated with Claude Code