feat: implement issue #606 — Story (B): channel-ify feature-ideation + pr-auto-review [#604] by don-petry · Pull Request #691 · petry-projects/.github

don-petry · 2026-07-13T02:05:55Z

Closes #606

Implemented by dev-lead agent. Please review.

Summary by CodeRabbit

Workflow Updates
- Updated the PR auto-review workflow to use its stable channel.
- Added feature ideation and PR auto-review workflows to the managed channel-based workflow set.
- Improved workflow guidance and clarified supported channel references.
Bug Fixes
- Compliance checks now correctly accept stable and ring channels while rejecting outdated fixed-version references.
Tests
- Expanded validation coverage for workflow channel eligibility and canonical references.

…+ pr-auto-review [#604]

chatgpt-codex-connector · 2026-07-13T02:06:00Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

coderabbitai · 2026-07-13T02:06:04Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 3de35ae9-73b1-449b-8d34-1aa672976b4c

📥 Commits

Reviewing files that changed from the base of the PR and between 0716cec and e1cfd11.

📒 Files selected for processing (6)

scripts/compliance-audit.sh
scripts/deploy-standard-workflows.sh
scripts/lib/ring-pins.sh
standards/workflows/pr-auto-review.yml
test/scripts/compliance-audit/centralized-stub-pins.bats
test/scripts/lib/ring-pins.bats

📝 Walkthrough

Walkthrough

The change moves feature-ideation and pr-auto-review into the ring-channel pin model, updates pr-auto-review to its stable channel, expands centralized audit coverage, and adds validation for canonical and legacy pins.

Changes

Reusable channel pin model

Layer / File(s)	Summary
Ring model and audit contracts `scripts/lib/ring-pins.sh`, `scripts/compliance-audit.sh`, `scripts/deploy-standard-workflows.sh`	Adds both reusable names to ring handling, changes `feature-ideation` to RING validation, enforces `pr-auto-review`, and updates related compliance documentation.
Stable channel workflow reference `standards/workflows/pr-auto-review.yml`	Updates guidance and changes the reusable workflow reference from `@v2` to `@pr-auto-review/stable`.
Channel pin validation tests `test/scripts/compliance-audit/centralized-stub-pins.bats`, `test/scripts/lib/ring-pins.bats`	Tests stable-channel acceptance, legacy-pin rejection, ring membership, and tier-specific canonical references for both reusables.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

petry-projects/.github#302: Updates centralized stub pin validation and canonical version tracking in the same compliance-audit area.

Suggested labels: needs-human-review

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Linked Issues check	⚠️ Warning	The PR updates ring pins, audit rules, tests, and pr-auto-review workflow, but it does not repin feature-ideation.yml to `@feature-ideation/stable` as required by `#606`.	Repin standards/workflows/feature-ideation.yml to `@feature-ideation/stable` and include it so both shims are fully channel-ified.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: channel-ifying feature-ideation and pr-auto-review for issue `#606`.
Out of Scope Changes check	✅ Passed	The changes stay focused on the `#606` shim-channeling work and its validation/tests, with no clear unrelated code introduced.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch dev-lead/issue-606-20260713-0153

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

don-petry · 2026-07-13T02:06:42Z

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

gemini-code-assist

Code Review

This pull request transitions the feature-ideation and pr-auto-review reusable workflows to the ring-based deployment model (moving channels) instead of fixed version pins. It updates the compliance audit scripts, deployment scripts, and standard workflow definitions, and adds corresponding test coverage to verify that these workflows correctly resolve to their respective tier channels. There are no review comments, so I have no feedback to provide.

don-petry · 2026-07-13T02:10:47Z

Dev-Lead — fix-reviews (no-changes)

Agent reasoning

Addressed 0 threads:
(none — open threads array is empty)
Test verification: PASS — 183/183 bats tests passed
Files changed: none
```
**Phase 0 summary:** All CI checks are `success` or `skipped` (one `dev-lead / dispatch` still `in_progress` but not failed). The single reviewer (`gemini-code-assist`) left a `COMMENTED` state (not `CHANGES_REQUESTED`). Zero Tier 1 blockers exist. No threads to address, no changes needed.

donpetry-bot

Automated review — APPROVED ✓

Risk: MEDIUM
Reviewed commit: 14f48f43f5921bd4a8338503c8fa7673f27c1c9c
Review mode: triage-approved (single reviewer)

Summary

Moves feature-ideation and pr-auto-review reusables onto the org-wide ring/channel deployment model per issue #606 (Story B of epic #604). Adds both to RING_REUSABLES, switches the compliance-audit centralized[] entries to the RING sentinel (pr-auto-review is now enforced for the first time), repins the pr-auto-review template from frozen @v2 to the @pr-auto-review/stable moving channel, and adds bats coverage for both. Verified out-of-band: the prerequisite channel tags (feature-ideation/{next,ring0,ring1,stable}, pr-auto-review/{next,ring0,ring1,stable}) are published, and the feature-ideation template already pins @feature-ideation/stable at HEAD.

Linked issue analysis

Closes #606. All checklist items are substantively addressed: (1) channel tags published — confirmed via git/matching-refs; (2) both base-names added to RING_REUSABLES in scripts/lib/ring-pins.sh; (3) both templates pin @/stable (pr-auto-review repinned in this PR; feature-ideation confirmed already on-channel at head SHA); (4) compliance-audit centralized[] updated — feature-ideation fixed-v1 → RING, pr-auto-review added as RING; (5) tests added for both new RING entries (ring-pins.bats + centralized-stub-pins.bats). Acceptance criteria met.

Findings

LOW (non-blocking): new test comments in centralized-stub-pins.bats reference issue #870 ("grace dropped, #870"), which does not exist in petry-projects/.github — likely a wrong issue number; worth fixing in a follow-up.
The switch from a frozen @v2 pin to the moving @pr-auto-review/stable channel is intentional and consistent with the org-wide decision recorded in #606 (first-party channel model, NOSONAR-annotated); rollback becomes a central tag move.
Dropping the @v1/@v2 legacy grace means caller repos still on old pins will be flagged by the audit and repinned by the deploy sweep — expected enforcement behavior per the issue.
Secret scan: run_secret_scanning MCP tool not available in this session; gitleaks CI check passed and diff contains no credential-like content.

CI status

All checks green: Lint, ShellCheck, Agent Security Scan, Secret scan (gitleaks), CodeQL, SonarCloud (Quality Gate passed, 0 new issues), Compliance Audit Tests, PR Auto-Review Tests, Standards Deploy Tests, npm audit, AgentShield. Skipped checks are ecosystem-conditional. The only in-progress check is the dev-lead agent-orchestration dispatch (this review cycle), not a CI gate. Branch is BEHIND main but MERGEABLE.

Reviewed automatically by the PR-review agent (single-reviewer mode: fable 5). Reply if you need a human review.

sonarqubecloud · 2026-07-13T02:12:07Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

don-petry · 2026-07-13T02:13:10Z

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning

Issues addressed: 0
- Quality gate passed with 0 new issues (no action required)
Files changed: None (no fixes needed)
Skipped (informational): 0
```
No changes required. The PR is ready for merge once in-progress checks (Analyze, CodeRabbit) complete.

donpetry-bot

Automated review — APPROVED ✓

Risk: MEDIUM
Reviewed commit: e1cfd11883824eb4625943dbead7702fa7f984ac
Review mode: triage-approved (single reviewer)

Summary

Channel-ifies the two off-model reusable shims (feature-ideation, pr-auto-review) per issue #606 (Story B of epic #604): adds both to RING_REUSABLES in scripts/lib/ring-pins.sh, switches the compliance-audit centralized[] entries to the RING sentinel (pr-auto-review is enforced for the first time), repins the pr-auto-review template from frozen @v2 to the @pr-auto-review/stable moving channel, and adds bats coverage for both. This is a confirmation re-review after a merge of main: the only delta since the previously approved SHA (14f48f4) is the merge commit bringing in PR #690 files (standards/ci-standards.md, standards/workflows/dev-lead.yml) — no new PR-authored changes.

Linked issue analysis

Closes #606 (now CLOSED). All checklist items verified at head SHA e1cfd11: (1) channel tags published — confirmed via git/matching-refs: feature-ideation/{next,ring0,ring1,stable} and pr-auto-review/{next,ring0,ring1,stable} all exist; (2) both base-names in RING_REUSABLES; (3) both templates pin @/stable — feature-ideation.yml verified on-channel at head (CodeRabbit's 'not repinned' warning is stale), pr-auto-review.yml repinned in this PR; (4) compliance-audit centralized[] updated (feature-ideation v1 → RING, pr-auto-review added as RING); (5) tests added in ring-pins.bats and centralized-stub-pins.bats. Acceptance criteria met.

Findings

Prior review's LOW finding carried forward (non-blocking): test comment in centralized-stub-pins.bats references '#870' ('grace dropped, #870'), which appears to be a wrong issue number — worth a follow-up fix.
No new issues introduced since the prior approved review; the merge commit only syncs main.
The frozen @v2 → moving @pr-auto-review/stable switch is the intentional org-wide first-party channel model (NOSONAR-annotated); rollback is a central tag move.
Secret scan: run_secret_scanning MCP tool not available in this session; gitleaks CI check passed and the diff contains no credential-like content.

CI status

All checks green at head SHA: Lint, ShellCheck, Agent Security Scan, Secret scan (gitleaks), CodeQL, SonarCloud (Quality Gate passed, 0 new issues), Compliance Audit Tests, PR Auto-Review Tests, Standards Deploy Tests, npm audit, AgentShield, CodeRabbit. Skipped checks are ecosystem-conditional (pnpm/cargo/pip/govulncheck, dependabot-automerge, ci-relay). CodeRabbit approved at head SHA; gemini-code-assist left a COMMENTED review with no actionable feedback; no unresolved review threads.

Reviewed automatically by the PR-review agent (single-reviewer mode: fable 5). Reply if you need a human review.

…+ pr-auto-review [#604] (#691) Co-authored-by: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com> Co-authored-by: Don Petry Bot <donpetry+bot@gmail.com>

feat: implement issue #606 — Story (B): channel-ify feature-ideation …

14f48f4

…+ pr-auto-review [#604]

don-petry requested a review from a team as a code owner July 13, 2026 02:05

don-petry enabled auto-merge (squash) July 13, 2026 02:06

gemini-code-assist Bot reviewed Jul 13, 2026

View reviewed changes

don-petry disabled auto-merge July 13, 2026 02:09

don-petry enabled auto-merge (squash) July 13, 2026 02:10

donpetry-bot approved these changes Jul 13, 2026

View reviewed changes

Merge branch 'main' into dev-lead/issue-606-20260713-0153

e1cfd11

don-petry disabled auto-merge July 13, 2026 02:12

don-petry enabled auto-merge (squash) July 13, 2026 02:13

don-petry merged commit 798d554 into main Jul 13, 2026
23 of 24 checks passed

don-petry deleted the dev-lead/issue-606-20260713-0153 branch July 13, 2026 02:13

coderabbitai Bot approved these changes Jul 13, 2026

View reviewed changes

donpetry-bot approved these changes Jul 13, 2026

View reviewed changes

coderabbitai Bot mentioned this pull request Jul 22, 2026

feat: implement issue #870 — [#850] standards-deploy driver deploys BROKEN dev-lead pins (@dev-lead/v14-* has no tag — uses release major, not channel major) #871

Merged

Navigation Menu

Uh oh!

feat: implement issue #606 — Story (B): channel-ify feature-ideation + pr-auto-review [#604] - #691

feat: implement issue #606 — Story (B): channel-ify feature-ideation + pr-auto-review [#604]#691
don-petry merged 2 commits into
mainfrom
dev-lead/issue-606-20260713-0153

don-petry commented Jul 13, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

chatgpt-codex-connector Bot commented Jul 13, 2026

Uh oh!

coderabbitai Bot commented Jul 13, 2026 •

edited

Loading

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

don-petry commented Jul 13, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

don-petry commented Jul 13, 2026

Uh oh!

donpetry-bot left a comment

Uh oh!

sonarqubecloud Bot commented Jul 13, 2026

Uh oh!

don-petry commented Jul 13, 2026

Uh oh!

Uh oh!

donpetry-bot left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

don-petry commented Jul 13, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

chatgpt-codex-connector Bot commented Jul 13, 2026

Uh oh!

coderabbitai Bot commented Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

don-petry commented Jul 13, 2026

Dev-Lead — review-changes (no-changes)

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

don-petry commented Jul 13, 2026

Dev-Lead — fix-reviews (no-changes)

Uh oh!

donpetry-bot left a comment

Choose a reason for hiding this comment

Automated review — APPROVED ✓

Summary

Linked issue analysis

Findings

CI status

Uh oh!

sonarqubecloud Bot commented Jul 13, 2026

Quality Gate passed

Uh oh!

don-petry commented Jul 13, 2026

Dev-Lead — fix-bot-comment (no-changes)

Uh oh!

Uh oh!

donpetry-bot left a comment

Choose a reason for hiding this comment

Automated review — APPROVED ✓

Summary

Linked issue analysis

Findings

CI status

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

don-petry commented Jul 13, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 13, 2026 •

edited

Loading