feat(#614): register feature-ideation in canary-rings.json — fleet drift now 0 - #661
Conversation
…ift now 0 Completes the feature-ideation channel/ring rollout (#614/#866). It already had feature-ideation/next + v1.0.0/v1.1.0 but was missing ring0/ring1/stable and was absent from the registry. Cut ring0/ring1/stable at v1.1.0 (all aligned on c60e75a = current next) and register it (host=.github, standard organic-traffic rings/gate mirroring agent-shield; run_workflow="Feature Research & Ideation (BMAD Analyst)"). Validated (read-only vs live tags): evaluate → COMPLETE (all channels on v1.1.0); **drift 1 → 0** — the entire fleet reusable registry is now in sync (every *-reusable.yml is registered or recorded as unmanaged). canary_rollout.bats green (+feature-ideation onboarding shape test). Remaining for #614: repin consumers onto their ring channels (.github→ring0, TalkTerm/bmad→ring1, google-app-scripts→stable, template→stable; .github-private already @next). Refs #614 #866. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reached
Next review available in: 49 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request onboards the feature-ideation agent to the canary rings configuration and adds corresponding validation tests in the BATS test suite. The feedback suggests optimizing the new test by invoking jq directly instead of spawning an unnecessary subshell with bash -c.
| [ "$status" -eq 0 ] | ||
| run jq -e '.agents["feature-ideation"].reusable == ".github/workflows/feature-ideation-reusable.yml"' "$RINGS" | ||
| [ "$status" -eq 0 ] | ||
| run bash -c "jq -r '.agents[\"feature-ideation\"].rings | sort_by(.order) | map(.channel) | join(\",\")' '$RINGS'" |
There was a problem hiding this comment.
Avoid spawning an unnecessary subshell with bash -c in BATS tests. You can invoke jq directly within the run wrapper, which is cleaner and more efficient.
run jq -r '.agents["feature-ideation"].rings | sort_by(.order) | map(.channel) | join(",")' "$RINGS"
|
There was a problem hiding this comment.
Pull request overview
Registers the feature-ideation reusable workflow in the org’s canary rollout source-of-truth (standards/canary-rings.json) so it participates in the standard next → ring0 → ring1 → stable promotion model, and adds a Bats test to prevent registry drift.
Changes:
- Add
feature-ideationtostandards/canary-rings.jsonwith standard ring membership and the default graduated gate configuration. - Add a
tests/canary_rollout.batsassertion to validate the new agent entry’s presence and key fields.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/canary_rollout.bats | Adds a regression test asserting feature-ideation is present in canary-rings.json with standard ring ordering and gate knobs. |
| standards/canary-rings.json | Registers feature-ideation as a managed canary agent (host/reusable/workflow name + rings + standard #548 gate defaults). |
| @test "canary-rings.json: feature-ideation onboarded (cross-repo host, standard rings, #614)" { | ||
| run jq -e '.agents["feature-ideation"].host == "petry-projects/.github"' "$RINGS" | ||
| [ "$status" -eq 0 ] | ||
| run jq -e '.agents["feature-ideation"].reusable == ".github/workflows/feature-ideation-reusable.yml"' "$RINGS" | ||
| [ "$status" -eq 0 ] | ||
| run bash -c "jq -r '.agents[\"feature-ideation\"].rings | sort_by(.order) | map(.channel) | join(\",\")' '$RINGS'" | ||
| [ "$output" = "next,ring0,ring1,stable" ] | ||
| run jq -e '.agents["feature-ideation"].gate.transitions["ring1->stable"].sample_min == 1' "$RINGS" | ||
| [ "$status" -eq 0 ] | ||
| run jq -e '.agents["feature-ideation"] | (has("next_tier_health_signal")|not) and (has("soak_start_ring")|not)' "$RINGS" | ||
| [ "$status" -eq 0 ] | ||
| } |
…ift now 0 (#661) Completes the feature-ideation channel/ring rollout (#614/#866). It already had feature-ideation/next + v1.0.0/v1.1.0 but was missing ring0/ring1/stable and was absent from the registry. Cut ring0/ring1/stable at v1.1.0 (all aligned on c60e75a = current next) and register it (host=.github, standard organic-traffic rings/gate mirroring agent-shield; run_workflow="Feature Research & Ideation (BMAD Analyst)"). Validated (read-only vs live tags): evaluate → COMPLETE (all channels on v1.1.0); **drift 1 → 0** — the entire fleet reusable registry is now in sync (every *-reusable.yml is registered or recorded as unmanaged). canary_rollout.bats green (+feature-ideation onboarding shape test). Remaining for #614: repin consumers onto their ring channels (.github→ring0, TalkTerm/bmad→ring1, google-app-scripts→stable, template→stable; .github-private already @next). Refs #614 #866. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ift now 0 (#661) Completes the feature-ideation channel/ring rollout (#614/#866). It already had feature-ideation/next + v1.0.0/v1.1.0 but was missing ring0/ring1/stable and was absent from the registry. Cut ring0/ring1/stable at v1.1.0 (all aligned on c60e75a = current next) and register it (host=.github, standard organic-traffic rings/gate mirroring agent-shield; run_workflow="Feature Research & Ideation (BMAD Analyst)"). Validated (read-only vs live tags): evaluate → COMPLETE (all channels on v1.1.0); **drift 1 → 0** — the entire fleet reusable registry is now in sync (every *-reusable.yml is registered or recorded as unmanaged). canary_rollout.bats green (+feature-ideation onboarding shape test). Remaining for #614: repin consumers onto their ring channels (.github→ring0, TalkTerm/bmad→ring1, google-app-scripts→stable, template→stable; .github-private already @next). Refs #614 #866. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ift now 0 (#661) Completes the feature-ideation channel/ring rollout (#614/#866). It already had feature-ideation/next + v1.0.0/v1.1.0 but was missing ring0/ring1/stable and was absent from the registry. Cut ring0/ring1/stable at v1.1.0 (all aligned on c60e75a = current next) and register it (host=.github, standard organic-traffic rings/gate mirroring agent-shield; run_workflow="Feature Research & Ideation (BMAD Analyst)"). Validated (read-only vs live tags): evaluate → COMPLETE (all channels on v1.1.0); **drift 1 → 0** — the entire fleet reusable registry is now in sync (every *-reusable.yml is registered or recorded as unmanaged). canary_rollout.bats green (+feature-ideation onboarding shape test). Remaining for #614: repin consumers onto their ring channels (.github→ring0, TalkTerm/bmad→ring1, google-app-scripts→stable, template→stable; .github-private already @next). Refs #614 #866. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Completes the feature-ideation channel/ring rollout (#614/#866). It had
feature-ideation/next+ v1.0.0/v1.1.0 but was missing ring0/ring1/stable and wasn't registered. Cut ring0/ring1/stable at v1.1.0 (aligned onc60e75af) + register (host=.github, standard rings/gate mirroring agent-shield).Validated:
evaluate→ COMPLETE;drift1 → 0 — the entire fleet reusable registry is now in sync.canary_rollout.bats97/97.Remaining for #614: repin consumers onto their ring channels (follow-up commits).
🤖 Generated with Claude Code