Skip to content

feat: implement issue #600 — [Phase 1] Open-questions-as-gate: withhold ready-for-dev on affected stories - #733

Closed
don-petry wants to merge 4 commits into
mainfrom
dev-lead/issue-600-20260614-2113
Closed

don-petry wants to merge 4 commits into
mainfrom
dev-lead/issue-600-20260614-2113

Conversation

@don-petry

Copy link
Copy Markdown
Collaborator

Closes #600

Implemented by dev-lead agent. Please review.

@don-petry
don-petry requested a review from a team as a code owner June 14, 2026 21:22
@coderabbitai

coderabbitai Bot commented Jun 14, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

@don-petry, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 38 minutes and 10 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 16e3cf8c-53bd-43bf-af01-57a327ed68ba

📥 Commits

Reviewing files that changed from the base of the PR and between 9b43d31 and 59d9919.

📒 Files selected for processing (7)
  • prompts/bmad/scrum-master.md
  • scripts/initiative-driver.sh
  • scripts/initiative-planner/apply-plan.sh
  • scripts/initiative-planner/plan.schema.json
  • scripts/initiative-planner/validate-plan.py
  • tests/test_initiative_driver.bats
  • tests/test_initiative_planner.bats
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev-lead/issue-600-20260614-2113

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

@don-petry
don-petry enabled auto-merge (squash) June 14, 2026 21:23

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a "needs-input" gate for non-blocking open questions that target specific stories. It updates apply-plan.sh to parse affected_story_ids from open questions, label affected stories with planning:needs-input (withholding their ready-for-dev status), and flag the parent epic with initiative:needs-input. Additionally, the JSON schema and the Python validation script are updated to support and validate these new fields, and comprehensive integration tests are added to verify the behavior. I have no feedback to provide as there are no review comments.

@don-petry
don-petry disabled auto-merge June 14, 2026 21:26
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — fix-reviews (no-changes)

Agent reasoning
Addressed 0 threads:
(no open threads)
Test verification: pass — all CI checks green (bats, unit-tests, shellcheck, ShellCheck, Lint, SonarCloud, CodeQL, Agent Security Scan all succeeded)
Files changed: none
```

@don-petry
don-petry enabled auto-merge (squash) June 14, 2026 21:27

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7c7613ddc7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/initiative-planner/apply-plan.sh
Comment thread scripts/initiative-planner/plan.schema.json
@don-petry
don-petry disabled auto-merge June 14, 2026 21:33
coderabbitai[bot]
coderabbitai Bot previously approved these changes Jun 14, 2026
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — fix-reviews (applied)

Changes committed and pushed.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@don-petry
don-petry disabled auto-merge June 14, 2026 21:38
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — waiting on PR blockers (intent: review-changes)

PR: #733
No changes were committed, but the PR still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews). The retry cron will re-attempt automatically. Next attempt after: 2026-06-14T22:08:38Z

@don-petry

Copy link
Copy Markdown
Collaborator Author

Note

@don-petry I reviewed this PR and no code changes were needed, but it still has blocking checks or reviews (failing or cancelled checks, or changes-requested reviews), so I cannot mark it done yet. I'll re-check automatically.
Next attempt after: 2026-06-14T22:08:38Z

@don-petry
don-petry enabled auto-merge (squash) June 14, 2026 21:38
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@don-petry
don-petry disabled auto-merge June 14, 2026 22:12
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

@don-petry
don-petry enabled auto-merge (squash) June 14, 2026 22:12
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@don-petry
don-petry disabled auto-merge June 14, 2026 22:33
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

@don-petry
don-petry enabled auto-merge (squash) June 14, 2026 22:33
@sonarqubecloud

Copy link
Copy Markdown

@don-petry
don-petry disabled auto-merge June 14, 2026 22:39
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning
Issues addressed: 0
No actionable issues found — Quality Gate passed.
Files changed: None
Skipped (informational): Coverage/Duplication metrics (non-actionable)
```
The pull request is clean. No fixes are needed.

@don-petry
don-petry enabled auto-merge (squash) June 14, 2026 22:39

Copy link
Copy Markdown
Collaborator Author

Closing as superseded. The open-questions gate already shipped via #682 → #707 (merged) as a hard blocking:true → create-nothing gate. Its source issue #600 was closed as a duplicate of #682, and this PR implements #600's earlier per-story "withhold ready-for-dev" design, which #707 replaced.

Closing to avoid layering a second, conflicting gate on top of #707. If the finer per-story behavior is ever wanted, it should be a fresh story under epic #597 (see the note on #600).


Generated by Claude Code

@don-petry don-petry closed this Jun 14, 2026
auto-merge was automatically disabled June 14, 2026 23:01

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Phase 1] Open-questions-as-gate: withhold ready-for-dev on affected stories

2 participants