Skip to content

fix(dev-lead): add visible body to applied status comments - #296

Merged
don-petry merged 1 commit into
mainfrom
fix/dev-lead-empty-applied-comments
May 20, 2026
Merged

don-petry merged 1 commit into
mainfrom
fix/dev-lead-empty-applied-comments

Conversation

@don-petry

Copy link
Copy Markdown
Collaborator

Summary

  • post_reviews_terminal builds the comment body from marker + optional summary. When summary is empty, the body is a bare HTML comment — GitHub renders it as invisible, making the comment appear empty.
  • fix-reviews, human-pr, and rebase applied-status calls were missing the summary argument; fix-bot-comment and human already had one.

Test plan

  • All 17 unit tests in test_fix_reviews.bats pass
  • Verify next fix-reviews applied / human-pr applied / rebase applied run produces a visible comment body

🤖 Generated with Claude Code

post_reviews_terminal with status=applied and no summary posted a
comment containing only an HTML marker, which GitHub renders as
invisible. fix-reviews, human-pr, and rebase intents were all affected.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings May 20, 2026 01:35
@coderabbitai

coderabbitai Bot commented May 20, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@don-petry has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 58 minutes and 17 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: de307a22-a5ed-4246-92f8-4741bc9822c6

📥 Commits

Reviewing files that changed from the base of the PR and between c2ff45c and 333b827.

📒 Files selected for processing (1)
  • scripts/dev-lead-fix-reviews.sh
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/dev-lead-empty-applied-comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud

Copy link
Copy Markdown

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Ensures Dev-Lead “applied” status comments are visible on GitHub by always providing a non-empty summary to post_reviews_terminal for intents that previously posted only an HTML marker (rendering as an apparently empty comment).

Changes:

  • Add a summary message to post_reviews_terminal calls for fix-reviews when changes are applied.
  • Add a summary message to post_reviews_terminal calls for human-pr when changes are applied.
  • Add a summary message to post_reviews_terminal calls for rebase when changes are applied.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@don-petry
don-petry merged commit b43c2e2 into main May 20, 2026
21 checks passed
@don-petry
don-petry deleted the fix/dev-lead-empty-applied-comments branch May 20, 2026 01:38

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the scripts/dev-lead-fix-reviews.sh script to include descriptive status messages when changes are successfully committed and pushed. The post_reviews_terminal function calls for 'fix-reviews', 'human-pr', and 'rebase' intents now include specific strings confirming the action taken. I have no feedback to provide as there were no review comments to evaluate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants