fix(ci): ensure gemini-cli installs in reusable dev-lead workflow - #220
Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
No description provided. |
|
Dev-Lead Fix CI — no-changesPR: #220 | SHA: |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 911069071c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| case "$DEV_LEAD_ENGINE" in | ||
| claude) | ||
| npm install -g @google/gemini-cli || true |
There was a problem hiding this comment.
If the npm install fails here (registry outage, package error, or runner/network issue), || true lets the workflow continue with no gemini binary. In the fix-ci path, a later Claude rate limit calls run_writer_with_fallback, which tries Gemini next; a missing binary returns 127 from the Gemini branch in scripts/engine.sh, and because that helper only continues on exit 2, the run aborts instead of reaching the newly installed Copilot fallback. Either fail this setup step or explicitly skip unavailable engines before trying them.
Useful? React with 👍 / 👎.
|
|
||
| case "$DEV_LEAD_ENGINE" in | ||
| claude) | ||
| npm install -g @google/gemini-cli || true |
There was a problem hiding this comment.
With this new install, Claude-primary runs can now reach the Gemini fallback, but run_writer_with_fallback captures the default model before switching engines (ENGINE_ACTION_MODEL is still claude-sonnet-4-6 from sourcing scripts/engine.sh) and then the Gemini branch invokes gemini --model "$model". In any Claude-rate-limit scenario this makes the fallback call Gemini with a Claude model name, so the newly enabled fallback fails as a CLI error instead of applying the fix.
Useful? React with 👍 / 👎.
Co-authored-by: Gemini CLI <gemini-cli@example.com>
Co-authored-by: Gemini CLI <gemini-cli@example.com>
Co-authored-by: Gemini CLI <gemini-cli@example.com>
Co-authored-by: Gemini CLI <gemini-cli@example.com>
Co-authored-by: Gemini CLI <gemini-cli@example.com>
Co-authored-by: Gemini CLI <gemini-cli@example.com>
Co-authored-by: Gemini CLI <gemini-cli@example.com>
Co-authored-by: Gemini CLI <gemini-cli@example.com>
This fixes a bug where the fallback logic was failing because gemini-cli was not installed when the engine was set to claude in the reusable workflow.