feat: implement issue #1727 — [Phase 2] Retarget run attribution to job/role level so the collapse doesn't blind the fleet monitor - #1789
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing |
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
Warning Review limit reachedNext included review available in 19 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe change adds pure run-attribution helpers for legacy workflows and collapsed ChangesRun attribution
Priority: ➖ Normal Estimated code review effort: 4 (Complex) | ~45 minutes Change: Feature · Severity of issue fixed: Medium Sequence Diagram(s)sequenceDiagram
participant FleetMonitor
participant GitHubActionsAPI
participant RunAttribution
participant Report
FleetMonitor->>GitHubActionsAPI: Find agent-ingress workflow and completed runs
FleetMonitor->>GitHubActionsAPI: Fetch jobs for each run
FleetMonitor->>RunAttribution: Normalize jobs into role outcomes
RunAttribution->>Report: Aggregate buckets and render attribution table
Report-->>FleetMonitor: Add attribution section to monitor output
Merge Risk: 🟠 High · up to Fleet and PR-review reports can present incomplete or misleading role health, so the attribution behavior should be corrected before merge. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Full details: Description checkExplanation The description includes a useful summary, change list, and impact statement. It omits the required Interaction contract section and Checklist, including the N/A selection and shellcheck and documentation checks. Full details: Linked Issues checkExplanation The pull request implements the main [ Resolution Remove ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
codeant-ai
Bot
added
the
size:XL
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new run-to-role attribution mechanism for the collapsed agent-ingress workflow by adding scripts/lib/run-attribution.sh and integrating it into scripts/fleet_monitor.sh and scripts/pr_review_health.sh, along with a BATS test suite. The review feedback suggests avoiding potential SIGPIPE failures in shell scripts by replacing pipes to head -1 with jq's built-in first function, and recommends asserting specific non-zero exit codes in tests instead of using generic [ "$status" -ne 0 ] checks.
![codeant-ai[bot]](https://avatars.githubusercontent.com/in/646884?s=60&v=4){kind=small}
|
Auto-rebase failed — merge conflict — this branch has conflicts with dev-lead will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention. To resolve manually instead: |
Dev-Lead — review-changes (applied)Changes committed and pushed. Requested items addressed:
|
|
CI checks on this PR are still running. The PR-review sweep re-reviews this PR automatically once the checks complete — no action is needed. Posted by the donpetry-bot PR-review cascade. |
|
Auto-rebase failed — merge conflict — this branch has conflicts with dev-lead will attempt to resolve this automatically. If it cannot, a follow-up comment will explain what needs manual attention. To resolve manually instead: |
|
pr-review approved on PARTIAL advisory evidence: 4/6 required advisory bots reported before the gate's head-age-timeout fallback proceeded. Recorded for the miss-rate metric (#1596). |
Dev-Lead — rate-limited (intent: rebase)PR: #1789 |
|
No description provided. |
…ob/role level so the collapse doesn't blind the fleet monitor
473d257 to
05d3264
Compare
Dev-Lead — rebase (applied)Rebase completed and pushed. |
Dev-Lead — fix-bot-comment (no-changes)Agent reasoning |
|
pr-review approved on PARTIAL advisory evidence: 4/6 required advisory bots reported before the gate's head-age-timeout fallback proceeded. Recorded for the miss-rate metric (#1596). |
|
pr-review approved on PARTIAL advisory evidence: 4/6 required advisory bots reported before the gate's quiescence-timeout fallback proceeded. Recorded for the miss-rate metric (#1596). |
|
pr-review approved on PARTIAL advisory evidence: 4/6 required advisory bots reported before the gate's head-age-timeout fallback proceeded. Recorded for the miss-rate metric (#1596). |
|
Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-09-20T21:29:44Z. |
|
pr-review approved on PARTIAL advisory evidence: 4/6 required advisory bots reported before the gate's head-age-timeout fallback proceeded. Recorded for the miss-rate metric (#1596). |
|
Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-09-21T01:04:32Z. |
|
pr-review approved on PARTIAL advisory evidence: 4/6 required advisory bots reported before the gate's quiescence-timeout fallback proceeded. Recorded for the miss-rate metric (#1596). |
|
CI checks on this PR are still running. The PR-review sweep re-reviews this PR automatically once the checks complete — no action is needed. Posted by the donpetry-bot PR-review cascade. |
|
Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-09-21T01:27:41Z. |
|
|
Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-09-21T01:43:10Z. |
|
pr-review approved on PARTIAL advisory evidence: 4/6 required advisory bots reported before the gate's head-age-timeout fallback proceeded. Recorded for the miss-rate metric (#1596). |
2 participants
User description
Closes #1727
Implemented by dev-lead agent. Please review.
Summary by CodeRabbit
New Features
Tests
CodeAnt-AI Description
Preserve per-role run health after workflows move to shared agent ingress
What Changed
pr-review-mentionsignal after the workflow collapseImpact
✅ Accurate per-role fleet failure counts after workflow collapse✅ Preserved PR-review health signals across workflow migration✅ Visible missing-run attribution instead of silent metric loss💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.