Skip to content

feat: implement issue #1635 — [Phase 3] Defer AGENTS.md's Scheduled workflows section to the canonical org standard - #1636

Merged
don-petry merged 3 commits into
mainfrom
dev-lead/issue-1635-20260901-0238
Sep 1, 2026
Merged

don-petry merged 3 commits into
mainfrom
dev-lead/issue-1635-20260901-0238

Conversation

@don-petry

@don-petry don-petry commented Sep 1, 2026 •

Copy link
Copy Markdown
Collaborator

User description

Closes #1635

Implemented by dev-lead agent. Please review.


CodeAnt-AI Description

Defer scheduled workflow timing guidance to the canonical organization standard

What Changed

  • AGENTS.md now links to the organization-wide standard as the single source of truth for off-peak scheduled workflow timing.
  • The local CI check remains in place and continues rejecting minute-0 schedules in repository workflow and documentation files.
  • The local guidance no longer duplicates the promoted timing rules, reducing the risk of conflicting instructions.

Impact

✅ Consistent scheduled workflow guidance across repositories
✅ Minute-0 workflow schedules remain blocked
✅ Fewer documentation conflicts during standards updates

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

…orkflows section to the canonical org standard
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@codeant-ai

codeant-ai Bot commented Sep 1, 2026 •

Copy link
Copy Markdown

🤖 CodeAnt AI — Review Status

Status Commit Started (UTC) Finished (UTC)
✅ Reviewed your PR a72bab6 Sep 01, 2026 · 02:42 02:42

@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing

@codeant-ai

codeant-ai Bot commented Sep 1, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@coderabbitai

coderabbitai Bot commented Sep 1, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Team

Run ID: afdec723-7bd9-4f83-a4f6-3fd1c77e34aa


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codeant-ai codeant-ai Bot added the size:S This PR changes 10-29 lines, ignoring generated files label Sep 1, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the AGENTS.md file to document that the off-peak scheduling rule has been promoted to an org-wide standard, replacing the local guidelines with a reference to the central repository while retaining the description of the local CI enforcement. The reviewer suggested simplifying a redundant markdown link to the promoted standard for better readability.

Comment thread AGENTS.md Outdated
@don-petry
don-petry enabled auto-merge (squash) September 1, 2026 02:43
@donpetry-bot

Copy link
Copy Markdown
Contributor

Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-09-01T03:43:56Z.

@don-petry
don-petry disabled auto-merge September 1, 2026 02:44
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — fix-reviews (applied)

Changes committed and pushed.

@don-petry
don-petry enabled auto-merge (squash) September 1, 2026 02:44
donpetry-bot
donpetry-bot previously approved these changes Sep 1, 2026

@donpetry-bot donpetry-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review — APPROVED ✓

Risk: LOW
Reviewed commit: a72bab6efa973cc3003c6c18a3f22ad5622ce732
Review mode: triage-approved (single reviewer)

Summary

Docs-only change to AGENTS.md replacing the repo-local 'Scheduled workflows' rules with a deferral pointer to the canonical org standard (standards/ci-standards.md, Scheduled Workflow Timing), per issue #1635. Repo-local CI enforcement detail is preserved and the upstream cross-reference is updated. No cron, script, or workflow changes.

Linked issue analysis

Closes #1635. All five acceptance criteria are met: (1) the section is now a short deferral blockquote pointing to petry-projects/.github → standards/ci-standards.md → Scheduled Workflow Timing, mirroring the Cost-reporting promotion precedent; (2) genuinely repo-local detail (the validate-workflow-schedules lint job, its script/tests, scope exclusions, and the note that it is distinct from the org's check-cron-timing.sh) is retained under the pointer; (3) the ~line 285 cross-reference in the Cost-reporting section is rewritten and still resolves; (4) only AGENTS.md changed — no cron expressions modified; (5) AGENTS.md-related CI (Lint) is green.

Findings

No blocking findings.

  • Advisory (non-blocking): gemini-code-assist left one unresolved low-priority style nit suggesting the org-standard link text be simplified (link text vs. trailing '→ standards/ci-standards.md' redundancy). Cosmetic only; fine to take or leave in a follow-up.
  • Secret scan: the run_secret_scanning MCP tool is not available in this environment; relying on the gitleaks CI check, which passed. No secrets or sensitive content in the diff (markdown documentation only).
  • Prior rate-limited marker (02:43:56Z) is satisfied: advisory bots have since reported (SonarCloud quality gate passed, CodeRabbit success status, gemini review posted).

CI status

All validation checks green: Lint, ShellCheck, unit-tests, Compile agentic workflows, Agent Security Scan, Secret scan (gitleaks), CodeQL (actions/python), SonarCloud quality gate, CodeRabbit, AgentShield, holdout-guard, Test-Deletion Guard, duplicate-decl-gate. CANCELLED entries are agent-orchestration jobs (dev-lead dispatch/ci-relay/resume, superseded review trigger), not code validation. Branch is BEHIND main but MERGEABLE.


Reviewed automatically by the PR-review agent (single-reviewer mode: fable 5). Reply if you need a human review.

@donpetry-bot

Copy link
Copy Markdown
Contributor

Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-09-01T03:46:07Z.

@don-petry
don-petry disabled auto-merge September 1, 2026 02:46
@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning
**Review status:** No `CHANGES_REQUESTED` reviews; the only comments are:
- `don-petry`: empty COMMENTED entry
- `donpetry-bot`: APPROVED with detailed analysis
- `gemini-code-assist`: cosmetic style nit (non-blocking)
**Conclusion:** No Tier 1 blockers exist, and the bot comment is a neutral overview announcing a passing quality gate—not a specific, actionable defect. Per the guardrails, there is nothing to fix.
---
**Bot:** SonarCloud  
**Issues addressed:** 0  
**Files changed:** None  
**Result:** No action needed — quality gate passed, zero blocking issues.

@don-petry
don-petry enabled auto-merge (squash) September 1, 2026 02:46

@donpetry-bot donpetry-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review — APPROVED ✓

Risk: LOW
Reviewed commit: 2e19688a063cc37a5950f46a3bf1a18556001b53
Review mode: triage-approved (single reviewer)

Summary

Docs-only change to a single file (AGENTS.md, +25/−29): replaces the repo-local "Scheduled workflows" section with a deferral pointer to the canonical org-wide standard (standards/ci-standards.md → Scheduled Workflow Timing in petry-projects/.github), while retaining the genuinely repo-local CI-enforcement detail (validate-workflow-schedules job) and updating the cross-reference above it. Verified the link target exists (section at line 1478 of the org standard) and the referenced scripts/check-cron-timing.sh exists in the org repo. No cron expressions or workflow files were touched. Triage assessment (low-risk) confirmed.

Linked issue analysis

Closes #1635. All five acceptance criteria are met: (1) section replaced by a short deferral pointer following the Cost-reporting precedent; (2) repo-local CI enforcement detail preserved under the pointer, explicitly noted as distinct from the org standard's check-cron-timing.sh; (3) the ~line 285 cross-reference updated to resolve after the rewrite; (4) documentation-only — no cron modified; (5) all lint/structural checks green.

Findings

No blocking findings. The one review thread (gemini-code-assist link-text nit on the org-standard link) was addressed by the follow-up commit 2e19688 and is resolved/outdated. Diff since the previously approved SHA (a72bab6) contains only that fix, confined to AGENTS.md. Secret scan: run_secret_scanning MCP tool unavailable in this session; the gitleaks CI check passed and the diff contains no secret-like content.

CI status

All required checks green: Lint, ShellCheck, unit-tests, CodeQL (actions + python), Agent Security Scan, AgentShield, Secret scan (gitleaks), SonarCloud quality gate, holdout-guard, duplicate-decl-gate, guard, Compile agentic workflows — all SUCCESS. One earlier review / review run was CANCELLED but superseded by a later SUCCESS run. Branch is BEHIND main but MERGEABLE (auto-rebase handles this).


Reviewed automatically by the PR-review agent (single-reviewer mode: fable 5). Reply if you need a human review.

@donpetry-bot
donpetry-bot dismissed their stale review September 1, 2026 02:48

Superseded by automated re-review at 2e19688.

@don-petry
don-petry disabled auto-merge September 1, 2026 02:48
@sonarqubecloud

sonarqubecloud Bot commented Sep 1, 2026

Copy link
Copy Markdown

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

@don-petry
don-petry merged commit 71c35c8 into main Sep 1, 2026
29 checks passed
@don-petry
don-petry deleted the dev-lead/issue-1635-20260901-0238 branch September 1, 2026 02:49
@donpetry-bot

Copy link
Copy Markdown
Contributor

Advisory bots were rate-limited; auto-approval is withheld until they recover. pr-review-sweep will re-review this PR after 2026-09-01T03:49:31Z.

@donpetry-bot donpetry-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review — APPROVED ✓

Risk: LOW
Reviewed commit: 0a73f66b9396fae0cda2f8651732417fb49622a0
Review mode: triage-approved (single reviewer)

Summary

Docs-only change to a single file (AGENTS.md, +25/−29) implementing issue #1635: replaces the repo-local 'Scheduled workflows' rules with a deferral blockquote pointing to the canonical org standard (petry-projects/.github → standards/ci-standards.md → Scheduled Workflow Timing), retains the genuinely repo-local CI enforcement detail (validate-workflow-schedules job, script, and bats tests — all verified to exist at the PR head), and updates the upstream cross-reference so it still resolves. No cron expressions, scripts, or workflows are modified. Since the prior approval at 2e19688, the only new commit is a merge of main (bringing in already-merged PR #1625); the PR's own diff is unchanged. Triage's low-risk assessment is confirmed.

Linked issue analysis

Closes #1635. All five acceptance criteria are met: (1) the section is now a short deferral pointer to the org standard, mirroring the Cost-reporting promotion precedent; (2) repo-local detail not covered by the org standard (the validate-workflow-schedules lint job, its script/tests, frameworks/ scope exclusion, and the note that it is distinct from the org's check-cron-timing.sh) is preserved under the pointer; (3) the ~line 285 cross-reference is rewritten and still resolves; (4) documentation-only — no cron modified; (5) lint/structural CI is green.

Findings

No blocking findings.

  • The single review thread (gemini-code-assist low-priority link-text nit) is resolved and outdated. No unanswered human-reviewer questions — all remaining PR comments are bot/automation status markers.
  • Secret scan: the run_secret_scanning MCP tool is not available in this environment; the gitleaks CI check passed and the docs-only diff contains no secret-like content.
  • Referenced files scripts/validate-workflow-schedules.sh and tests/test_validate_workflow_schedules.bats verified present at the reviewed commit.

CI status

All checks green at 0a73f66: Lint, ShellCheck, unit-tests, CodeQL (actions + python), Agent Security Scan, AgentShield, Secret scan (gitleaks), SonarCloud quality gate, holdout-guard, duplicate-decl-gate, and remaining checks SUCCESS; ecosystem-specific dependency audits and dependabot/spec-drift jobs SKIPPED as expected for a docs-only change.


Reviewed automatically by the PR-review agent (single-reviewer mode: fable 5). Reply if you need a human review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Phase 3] Defer AGENTS.md's Scheduled workflows section to the canonical org standard

2 participants