Skip to content

fix(pr-review): unbreak reviews — stub must not forward lsp_pilot_variant to the pinned channel - #1048

Merged
don-petry merged 2 commits into
mainfrom
claude/mcp-review-enrichment-6h269j
Jul 3, 2026
Merged

don-petry merged 2 commits into
mainfrom
claude/mcp-review-enrichment-6h269j

Conversation

@don-petry

Copy link
Copy Markdown
Collaborator

🔴 Production hotfix — every pr-review has been failing with startup_failure

Since #1034 merged (2026-07-03), every pr-review-trigger run has ended in startup_failure (confirmed across the last 15+ runs on main). No PR is getting reviewed.

Root cause — release-channel skew

#1034 modified the thin ring-0 caller stub (pr-review-trigger.yml) to forward a new lsp_pilot_variant input to pr-review.yml@pr-review/next. But the pinned channel pr-review/next (ded84ce) is behind #1034 and does not declare that input. Passing a with: key the called reusable doesn't declare is an invalid workflow → startup_failure on every review — even with an empty value, and for event-triggered runs.

This is the thin-caller-stub hazard called out in CLAUDE.md / the stub's own header ("this file only changes when the ring-0 channel itself changes"): the stub was changed to forward an input ahead of the channel that defines it.

Fix

Remove the premature lsp_pilot_variant dispatch input + its forwarding from the stub, restoring its with: block byte-for-byte to the pre-#1034 set (18 deletions, one file). Nothing else changes.

pr-review.yml on main keeps its lsp_pilot_variant input + env/gating logic — it's harmless there. The stub forwarding should be re-added only after pr-review/next is advanced (via cut-release.sh --channel) to a commit that declares the input, so the stub and the channel it pins stay in lockstep.

Validation

  • pr-review-trigger.yml parses as YAML; no lsp_pilot_variant reference remains in the stub.
  • Diff is deletions-only against main.

Follow-up (separate, non-urgent)

Re-enable the pilot A/B on this repo's PRs the right way: advance pr-review/next to include #1034 first, then reintroduce the stub forwarding. Tracked against epic #839 / #844.

🤖 Generated with Claude Code


Generated by Claude Code

…channel (unbreak reviews)

Every pr-review run has been failing with startup_failure since #1034 merged.

Root cause: release-channel skew. #1034 modified the thin ring-0 caller stub
(pr-review-trigger.yml) to forward a new `lsp_pilot_variant` input to
`pr-review.yml@pr-review/next`, but that pinned channel (ded84ce) is behind
#1034 and does NOT declare the input. Passing a `with:` key the called reusable
doesn't declare is an invalid workflow → startup_failure on EVERY review (even
with an empty value, and for event triggers).

Fix: remove the premature `lsp_pilot_variant` dispatch input + its forwarding
from the stub, restoring it byte-for-byte to its pre-#1034 `with:` set. The stub
must not forward an input the pinned channel doesn't yet support. pr-review.yml
on main keeps the input/env logic; the stub forwarding can be re-added once
`pr-review/next` is advanced (via cut-release.sh) to a commit that declares it.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016Y3xW3cnB5wscv4SmjSNEr
Copilot AI review requested due to automatic review settings July 3, 2026 13:35
@don-petry
don-petry requested a review from a team as a code owner July 3, 2026 13:35
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@gemini-code-assist

Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@coderabbitai

coderabbitai Bot commented Jul 3, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

@don-petry, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 55 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: ffaa0fbf-3431-4bbe-9528-caba14015e57

📥 Commits

Reviewing files that changed from the base of the PR and between 4485a5b and f5afd87.

📒 Files selected for processing (2)
  • .github/workflows/pr-review-trigger.yml
  • tests/dev-lead/integration/test_pr_review_lsp_pilot_plumbing.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/mcp-review-enrichment-6h269j

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR is a production hotfix to restore pr-review-trigger workflow execution by removing an undeclared reusable-workflow input (lsp_pilot_variant) from the thin caller stub, which was causing startup_failure when calling the pinned pr-review/next channel.

Changes:

  • Removes the workflow_dispatch input definition for lsp_pilot_variant from pr-review-trigger.yml.
  • Stops forwarding lsp_pilot_variant in the with: block to the pinned reusable pr-review.yml@pr-review/next, avoiding invalid-input startup failures.

…fety check

The guard added in #1034 asserted the ring-0 stub FORWARDS lsp_pilot_variant —
the exact behaviour that startup_failed every review (the stub pins
@pr-review/next, which doesn't declare the input). Invert check_trigger so it
now fails if the stub declares/forwards the input ahead of the pinned channel,
matching the revert in the previous commit. This both unbreaks the guard on this
PR and would have caught #1034 before merge. Re-enable procedure documented in
the module docstring: advance pr-review/next to declare the input, then re-add
the stub forwarding and flip this check back.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016Y3xW3cnB5wscv4SmjSNEr
@sonarqubecloud

sonarqubecloud Bot commented Jul 3, 2026

Copy link
Copy Markdown

@don-petry

Copy link
Copy Markdown
Collaborator Author

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning
Issues addressed: 0
Files changed: tests/dev-lead/integration/test_pr_review_lsp_pilot_plumbing.py
Skipped (informational): 0
No actionable issues — Quality Gate passed with zero new issues and zero security hotspots.
```
The PR is in good shape. All quality gates pass with no bugs, vulnerabilities, or code smells detected.

@don-petry
don-petry enabled auto-merge (squash) July 3, 2026 13:41
@don-petry
don-petry merged commit d85a373 into main Jul 3, 2026
38 of 40 checks passed
@don-petry
don-petry deleted the claude/mcp-review-enrichment-6h269j branch July 3, 2026 14:24
don-petry added a commit that referenced this pull request Aug 2, 2026
…iant to the pinned channel (#1048)

Production hotfix: #1034 made the ring-0 trigger stub forward a lsp_pilot_variant input that pr-review.yml@pr-review/next does not declare, causing startup_failure on every review. Restore the stub's with: block to the pre-#1034 set. Re-add forwarding only after pr-review/next is advanced to declare the input (epic #839/#844).
don-petry added a commit that referenced this pull request Aug 3, 2026
…iant to the pinned channel (#1048)

Production hotfix: #1034 made the ring-0 trigger stub forward a lsp_pilot_variant input that pr-review.yml@pr-review/next does not declare, causing startup_failure on every review. Restore the stub's with: block to the pre-#1034 set. Re-add forwarding only after pr-review/next is advanced to declare the input (epic #839/#844).
don-petry added a commit that referenced this pull request Aug 3, 2026
…iant to the pinned channel (#1048)

Production hotfix: #1034 made the ring-0 trigger stub forward a lsp_pilot_variant input that pr-review.yml@pr-review/next does not declare, causing startup_failure on every review. Restore the stub's with: block to the pre-#1034 set. Re-add forwarding only after pr-review/next is advanced to declare the input (epic #839/#844).
don-petry added a commit that referenced this pull request Aug 3, 2026
…iant to the pinned channel (#1048)

Production hotfix: #1034 made the ring-0 trigger stub forward a lsp_pilot_variant input that pr-review.yml@pr-review/next does not declare, causing startup_failure on every review. Restore the stub's with: block to the pre-#1034 set. Re-add forwarding only after pr-review/next is advanced to declare the input (epic #839/#844).
don-petry added a commit that referenced this pull request Aug 7, 2026
…iant to the pinned channel (#1048)

Production hotfix: #1034 made the ring-0 trigger stub forward a lsp_pilot_variant input that pr-review.yml@pr-review/next does not declare, causing startup_failure on every review. Restore the stub's with: block to the pre-#1034 set. Re-add forwarding only after pr-review/next is advanced to declare the input (epic #839/#844).
don-petry added a commit that referenced this pull request Aug 7, 2026
…iant to the pinned channel (#1048)

Production hotfix: #1034 made the ring-0 trigger stub forward a lsp_pilot_variant input that pr-review.yml@pr-review/next does not declare, causing startup_failure on every review. Restore the stub's with: block to the pre-#1034 set. Re-add forwarding only after pr-review/next is advanced to declare the input (epic #839/#844).
don-petry added a commit that referenced this pull request Aug 7, 2026
…iant to the pinned channel (#1048)

Production hotfix: #1034 made the ring-0 trigger stub forward a lsp_pilot_variant input that pr-review.yml@pr-review/next does not declare, causing startup_failure on every review. Restore the stub's with: block to the pre-#1034 set. Re-add forwarding only after pr-review/next is advanced to declare the input (epic #839/#844).
don-petry added a commit that referenced this pull request Aug 7, 2026
…iant to the pinned channel (#1048)

Production hotfix: #1034 made the ring-0 trigger stub forward a lsp_pilot_variant input that pr-review.yml@pr-review/next does not declare, causing startup_failure on every review. Restore the stub's with: block to the pre-#1034 set. Re-add forwarding only after pr-review/next is advanced to declare the input (epic #839/#844).
don-petry added a commit that referenced this pull request Aug 7, 2026
…iant to the pinned channel (#1048)

Production hotfix: #1034 made the ring-0 trigger stub forward a lsp_pilot_variant input that pr-review.yml@pr-review/next does not declare, causing startup_failure on every review. Restore the stub's with: block to the pre-#1034 set. Re-add forwarding only after pr-review/next is advanced to declare the input (epic #839/#844).
don-petry added a commit that referenced this pull request Aug 7, 2026
…iant to the pinned channel (#1048)

Production hotfix: #1034 made the ring-0 trigger stub forward a lsp_pilot_variant input that pr-review.yml@pr-review/next does not declare, causing startup_failure on every review. Restore the stub's with: block to the pre-#1034 set. Re-add forwarding only after pr-review/next is advanced to declare the input (epic #839/#844).
don-petry added a commit that referenced this pull request Aug 7, 2026
…iant to the pinned channel (#1048)

Production hotfix: #1034 made the ring-0 trigger stub forward a lsp_pilot_variant input that pr-review.yml@pr-review/next does not declare, causing startup_failure on every review. Restore the stub's with: block to the pre-#1034 set. Re-add forwarding only after pr-review/next is advanced to declare the input (epic #839/#844).
don-petry added a commit that referenced this pull request Aug 7, 2026
…iant to the pinned channel (#1048)

Production hotfix: #1034 made the ring-0 trigger stub forward a lsp_pilot_variant input that pr-review.yml@pr-review/next does not declare, causing startup_failure on every review. Restore the stub's with: block to the pre-#1034 set. Re-add forwarding only after pr-review/next is advanced to declare the input (epic #839/#844).
don-petry added a commit that referenced this pull request Aug 7, 2026
…iant to the pinned channel (#1048)

Production hotfix: #1034 made the ring-0 trigger stub forward a lsp_pilot_variant input that pr-review.yml@pr-review/next does not declare, causing startup_failure on every review. Restore the stub's with: block to the pre-#1034 set. Re-add forwarding only after pr-review/next is advanced to declare the input (epic #839/#844).
don-petry added a commit that referenced this pull request Aug 7, 2026
…iant to the pinned channel (#1048)

Production hotfix: #1034 made the ring-0 trigger stub forward a lsp_pilot_variant input that pr-review.yml@pr-review/next does not declare, causing startup_failure on every review. Restore the stub's with: block to the pre-#1034 set. Re-add forwarding only after pr-review/next is advanced to declare the input (epic #839/#844).
don-petry added a commit that referenced this pull request Aug 8, 2026
…iant to the pinned channel (#1048)

Production hotfix: #1034 made the ring-0 trigger stub forward a lsp_pilot_variant input that pr-review.yml@pr-review/next does not declare, causing startup_failure on every review. Restore the stub's with: block to the pre-#1034 set. Re-add forwarding only after pr-review/next is advanced to declare the input (epic #839/#844).
don-petry added a commit that referenced this pull request Aug 8, 2026
…iant to the pinned channel (#1048)

Production hotfix: #1034 made the ring-0 trigger stub forward a lsp_pilot_variant input that pr-review.yml@pr-review/next does not declare, causing startup_failure on every review. Restore the stub's with: block to the pre-#1034 set. Re-add forwarding only after pr-review/next is advanced to declare the input (epic #839/#844).
don-petry added a commit that referenced this pull request Aug 8, 2026
…iant to the pinned channel (#1048)

Production hotfix: #1034 made the ring-0 trigger stub forward a lsp_pilot_variant input that pr-review.yml@pr-review/next does not declare, causing startup_failure on every review. Restore the stub's with: block to the pre-#1034 set. Re-add forwarding only after pr-review/next is advanced to declare the input (epic #839/#844).
don-petry added a commit that referenced this pull request Aug 8, 2026
…iant to the pinned channel (#1048)

Production hotfix: #1034 made the ring-0 trigger stub forward a lsp_pilot_variant input that pr-review.yml@pr-review/next does not declare, causing startup_failure on every review. Restore the stub's with: block to the pre-#1034 set. Re-add forwarding only after pr-review/next is advanced to declare the input (epic #839/#844).
don-petry added a commit that referenced this pull request Aug 18, 2026
…iant to the pinned channel (#1048)

Production hotfix: #1034 made the ring-0 trigger stub forward a lsp_pilot_variant input that pr-review.yml@pr-review/next does not declare, causing startup_failure on every review. Restore the stub's with: block to the pre-#1034 set. Re-add forwarding only after pr-review/next is advanced to declare the input (epic #839/#844).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants