Gate: explicit "End shift" button (clears scanner session server-side)#1072
Merged
Conversation
…utton End shift POSTs GateController.EndShift to clear the scanner session server-side and return to the claim screen, so a walk-away can't leave the next person's scans attributed to whoever last claimed (the old "Change" link only navigated away, leaving the ~8h session intact). Live-verified end-to-end; docs/sections/Gate.md invariant updated. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the gate scanning screen's faint "Change" text-link with an explicit two-tap "End shift" button.
Why
"Change" only navigated to the claim screen — it did not clear the per-person scanner session. Since the session lives ~8h, a volunteer who walked away left the next person's scans attributed to whoever last claimed. It also read as "I picked the wrong name", not "I'm done — next person".
What
GateController.EndShift([HttpPost],GateAdmit, antiforgery) clears the scanner session server-side, then returns to "Who is scanning?"./Gatenow correctly lands on the claim screen with no lingering attribution.Verification
Build clean · gate tests green ·
dotnet formatclean · live-verified end-to-end on the tablet viewport (two-tap arm, POST, session cleared,/Gate→ claim). Peer-reviewed (no blockers).docs/sections/Gate.mdinvariant updated.Not for merge without your review.
🤖 Generated with Claude Code