qa: unset LC_ALL in the check script to fix locale-dependent sort order#2587
Open
kurik wants to merge 1 commit intoperformancecopilot:mainfrom
Open
qa: unset LC_ALL in the check script to fix locale-dependent sort order#2587kurik wants to merge 1 commit intoperformancecopilot:mainfrom
kurik wants to merge 1 commit intoperformancecopilot:mainfrom
Conversation
When LC_ALL is set in the caller's environment (e.g. LC_ALL=en_US.utf8), it overrides any per-command LC_COLLATE=POSIX setting used inside individual QA tests, causing locale-sensitive sort ordering instead of the expected POSIX byte-value ordering. This manifests as spurious output mismatches in tests such as 821/1663 where metric names are enumerated via "LC_COLLATE=POSIX sort". Unsetting LC_ALL at the start of the check script removes the inherited override while still allowing individual tests to apply their own per-command locale settings (e.g. "LC_COLLATE=en_US.utf8 sort") as intended by their authors.
Contributor
Author
|
@kmcdonell May I ask you please for a review, to confirm this idea? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When LC_ALL is set in the caller's environment (e.g. LC_ALL=en_US.utf8),
it overrides any per-command LC_COLLATE=POSIX setting used inside
individual QA tests, causing locale-sensitive sort ordering instead of
the expected POSIX byte-value ordering. This manifests as spurious
output mismatches in tests such as 821/1663 where metric names are
enumerated via "LC_COLLATE=POSIX sort".
Unsetting LC_ALL at the start of the check script removes the inherited
override while still allowing individual tests to apply their own
per-command locale settings (e.g. "LC_COLLATE=en_US.utf8 sort") as
intended by their authors.