libpcp: recover from corrupted archives in multi-archive contexts#2586
Open
kurik wants to merge 1 commit intoperformancecopilot:mainfrom
Open
libpcp: recover from corrupted archives in multi-archive contexts#2586kurik wants to merge 1 commit intoperformancecopilot:mainfrom
kurik wants to merge 1 commit intoperformancecopilot:mainfrom
Conversation
When reading multi-archive PCP logs (e.g. Cockpit metrics history), a corrupted volume no longer terminates the entire replay. Instead, corrupted archives are flagged and skipped so that data from healthy volumes can still be read. - Add 'corrupted' field to __pmMultiLogCtl to track damaged archives - Skip corrupt/unreadable archives during multi-archive context init with a warning rather than failing outright - Rebuild shared __pmLogCtl when lost due to failed archive opens - On PM_ERR_LOGREC in __pmLogRead, advance to the next (or previous) archive instead of returning an error in multi-archive mode - Skip known-corrupted archives in LogChangeToNextArchive() and LogChangeToPreviousArchive() - Update QA tests 722 and 1671 for new recovery behaviour Resolves: RHEL-169855
Contributor
Author
|
@natoscott , @kmcdonell May I ask you for a review, please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When reading multi-archive PCP logs (e.g. Cockpit metrics history), a corrupted volume no longer terminates the entire replay. Instead, corrupted archives are flagged and skipped so that data from healthy volumes can still be read.
Resolves: RHEL-169855