Repository navigation
PMM-4379 Add stubs for updates API. - #395
Conversation
| // Package version provides helpers for working with versions and build info. | ||
| package version | ||
|
|
||
| /* |
There was a problem hiding this comment.
This code "works", but I would prefer not to use it if we can. It will be apparent if we need it or not soon.
There was a problem hiding this comment.
Why? Let's remove this file instead of commenting then.
There was a problem hiding this comment.
After this PR is squashed and merged, this code will be garbage collected by git / GitHub. It will be much harder to recover.
But after sleeping on it tonight, I'm 90% sure we will not need it. I will keep just in case in the git history but will remove in a next commit.
| /.vscode/ | ||
|
|
||
| /api/vendor/ | ||
| /vendor/ |
There was a problem hiding this comment.
Could you give some additional info, why have you moved vendor to root project directory?
There was a problem hiding this comment.
vendor/ moved to root just because of Gopkg.toml / Gopkg.lock moved to root.
Gopkg moved to root to properly add dependencies for /utils/pdeathsig package. /api/Gopkg.toml can't see /utils/... packages.
As a side effect, it actually fixed a problem of "key dependencies" versions not being fixed in downstream projects. Thanks to that we can remove hacks in them.
| message VersionResponse { | ||
| // Full PMM version. | ||
| // Managed describes pmm-managed build information. | ||
| message Managed { |
There was a problem hiding this comment.
Is it possible to have different version of pmm-managed and pmm-server?
There was a problem hiding this comment.
Yes, during update. This field describes version embedded into pmm-managed binary during the build. Other fields describe version from RPM.
But this field exists mostly to debug build problems – and we actually found several thanks to it.
| // Package version provides helpers for working with versions and build info. | ||
| package version | ||
|
|
||
| /* |
There was a problem hiding this comment.
Why? Let's remove this file instead of commenting then.
4 participants
No description provided.