Skip to content
This repository was archived by the owner on Jun 21, 2022. It is now read-only.

PMM-2385 golang 1.10 - #42

Merged
rnovikovP merged 4 commits into
masterfrom
golang-1.10
May 24, 2018
Merged

PMM-2385 golang 1.10#42
rnovikovP merged 4 commits into
masterfrom
golang-1.10

Conversation

@arvenil

@arvenil arvenil commented Apr 10, 2018

Copy link
Copy Markdown
Contributor

No description provided.

@arvenil arvenil changed the title golang 1.10 PMM-2385 golang 1.10 Apr 10, 2018
@codecov

codecov Bot commented Apr 10, 2018

Copy link
Copy Markdown

Codecov Report

Merging #42 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #42   +/-   ##
=======================================
  Coverage   50.39%   50.39%           
=======================================
  Files          42       42           
  Lines        3921     3921           
=======================================
  Hits         1976     1976           
  Misses       1683     1683           
  Partials      262      262
Impacted Files Coverage Δ
services/logs/logs.go 64.63% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99d4120...a907494. Read the comment docs.

@arvenil
arvenil requested a review from rnovikovP April 10, 2018 11:56
@AlekSi

AlekSi commented Apr 11, 2018

Copy link
Copy Markdown
Contributor

Already done in PMM-1.10 branch

@AlekSi

AlekSi commented Apr 11, 2018

Copy link
Copy Markdown
Contributor

See #45.

@arvenil

arvenil commented Apr 16, 2018

Copy link
Copy Markdown
Contributor Author

@AlekSi Why #45 is needed for just updating golang to 1.10?

@arvenil arvenil closed this May 10, 2018
@arvenil
arvenil deleted the golang-1.10 branch May 17, 2018 14:51
@arvenil
arvenil restored the golang-1.10 branch May 17, 2018 18:09
@arvenil arvenil reopened this May 17, 2018
rnovikovP
rnovikovP previously approved these changes May 24, 2018
@rnovikovP
rnovikovP merged commit ac0986d into master May 24, 2018
@arvenil
arvenil deleted the golang-1.10 branch May 26, 2018 08:40
askomorokhov pushed a commit that referenced this pull request Mar 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants