fix(storage-vercel-blob): add response.ok check and downloadUrl fallback in staticHandler (#16186)#16188
Open
deepshekhardas wants to merge 1 commit intopayloadcms:mainfrom
Conversation
…ack in staticHandler (payloadcms#16186) Added fallback to downloadUrl when CDN fetch returns non-ok response This prevents error page HTML from being returned as file data Fixes payloadcms#16186
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16186 - staticHandler does not check response.ok after CDN fetch
Problem: When CDN fetch fails (404 or non-200), error page HTML was returned as file data
Solution: Added response.ok check with fallback to downloadUrl from head() response