Skip to content

added update spending limit functionality #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alikhabazian merged 2 commits into from
Oct 12, 2023
Merged

added update spending limit functionality #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
673cc33
added update spending limit functionality
mehrdadmms Oct 12, 2023
24170a0
Merge branch 'main' into update-spending-limit
alikhabazian Oct 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/WorkingCapital.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,16 @@ import {IHats} from "./../hatsprotocol/src/Interfaces/IHats.sol";

contract WorkingCapital is PluginCloneable {


bytes32 public constant UPDATE_SPENDING_LIMIT_PERMISSION_ID = keccak256('UPDATE_SPENDING_LIMIT_PERMISSION');

struct MyAction {
address to;
uint256 value;
address ERC20;
}


IHats public hatsProtocolInstance;
uint256 public hatId;
mapping(address => uint256) public spendingLimit;
Expand Down Expand Up @@ -114,4 +118,9 @@ contract WorkingCapital is PluginCloneable {
IDAO.Action [] idaoAction = hasRemainingBudget(_myActions);
dao().execute({_callId: 0x0, _actions: idaoAction, _allowFailureMap: 0});
}

/// @param _spendingLimitETH The ETH spending limit
function updateSpendingLimit(uint256 _spendingLimitETH) external auth(UPDATE_SPENDING_LIMIT_PERMISSION_ID){
spendingLimitETH = _spendingLimitETH;
}
}
20 changes: 18 additions & 2 deletions src/WorkingCapitalSetup.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ contract WorkingCapitalSetup is PluginSetup {

// Prepare permissions
PermissionLib.MultiTargetPermission[]
memory permissions = new PermissionLib.MultiTargetPermission[](1);
memory permissions = new PermissionLib.MultiTargetPermission[](2);

// Grant the `EXECUTE_PERMISSION` on the DAO to the plugin.
permissions[0] = PermissionLib.MultiTargetPermission({
Expand All @@ -55,6 +55,14 @@ contract WorkingCapitalSetup is PluginSetup {
permissionId: DAO(payable(_dao)).EXECUTE_PERMISSION_ID()
});

permissions[1] = PermissionLib.MultiTargetPermission({
operation: PermissionLib.Operation.Grant,
where: plugin,
who: _dao,
condition: PermissionLib.NO_CONDITION,
permissionId: WorkingCapital(plugin).UPDATE_SPENDING_LIMIT_PERMISSION_ID()
});

preparedSetupData.permissions = permissions;
}

Expand All @@ -71,7 +79,7 @@ contract WorkingCapitalSetup is PluginSetup {
address plugin = _payload.plugin;

// Prepare permissions
permissions = new PermissionLib.MultiTargetPermission[](1);
permissions = new PermissionLib.MultiTargetPermission[](2);

permissions[0] = PermissionLib.MultiTargetPermission({
operation: PermissionLib.Operation.Revoke,
Expand All @@ -80,6 +88,14 @@ contract WorkingCapitalSetup is PluginSetup {
condition: PermissionLib.NO_CONDITION,
permissionId: DAO(payable(_dao)).EXECUTE_PERMISSION_ID()
});

permissions[0] = PermissionLib.MultiTargetPermission({
operation: PermissionLib.Operation.Revoke,
where: plugin,
who: _dao,
condition: PermissionLib.NO_CONDITION,
permissionId: WorkingCapital(plugin).UPDATE_SPENDING_LIMIT_PERMISSION_ID()
});
}

/// @inheritdoc IPluginSetup
Expand Down