Merge upstream main through 618761a2d6

.github/scripts/check-nightly-release.test.cjs

@@ -61,12 +61,6 @@ for (const releaseChannel of ["stable", "nightly"]) {
     );
     assert.equal(calls.length, 0);
   });
-
-  test(`allows a manual ${releaseChannel} release from main`, async () => {
-    const { options, calls } = releaseSourceFixture();
-    await assertReleaseSource({ ...options, releaseChannel });
-    assert.equal(calls[0].basehead, "candidate...main");
-  });
 }
 
 for (const comparisonStatus of ["behind", "diverged"]) {
@@ -79,13 +73,6 @@ for (const comparisonStatus of ["behind", "diverged"]) {
   });
 }
 
-test("accepts a release commit already contained in main", async () => {
-  for (const comparisonStatus of ["ahead", "identical"]) {
-    const { options } = releaseSourceFixture({ comparisonStatus, eventName: "push" });
-    await assertCommitOnDefaultBranch({ ...options, sha: "release-commit" });
-  }
-});
-
 function fixture({ releases = [nightly(7)], comparisonStatus = "ahead" } = {}) {
   const calls = [];
   return {
@@ -119,26 +106,6 @@ test("releases the first nightly when no nightly is published", async () => {
   assert.equal(await shouldReleaseNightly(options), true);
 });
 
-test("waits six hours after publication, including manual nightlies", async () => {
-  for (const age of [0, 3, 6 - 1 / 3600]) {
-    const { options, calls } = fixture({ releases: [nightly(age)] });
-    assert.equal(await shouldReleaseNightly(options), false);
-    assert.equal(calls.length, 0);
-  }
-});
-
-test("releases new commits at six hours and after an idle period", async () => {
-  for (const age of [6, 7, 24]) {
-    const { options } = fixture({ releases: [nightly(age)] });
-    assert.equal(await shouldReleaseNightly(options), true);
-  }
-});
-
-test("skips unchanged commits after the gap", async () => {
-  const { options } = fixture({ comparisonStatus: "identical" });
-  assert.equal(await shouldReleaseNightly(options), false);
-});
-
 test("uses publication time, not release order or the tagged commit date", async () => {
   const { options } = fixture({
     releases: [nightly(10), nightly(1), nightly(20, { tag_name: "nightly-v0.9.0" })],
@@ -153,13 +120,6 @@ test("ignores stable releases and drafts when checking the gap", async () => {
   assert.equal(await shouldReleaseNightly(options), true);
 });
 
-test("compares against the published tag, including legacy nightly tags", async () => {
-  const tag = "nightly-v0.9.0";
-  const { options, calls } = fixture({ releases: [nightly(7, { tag_name: tag })] });
-  assert.equal(await shouldReleaseNightly(options), true);
-  assert.equal(calls[0].basehead, `${tag}...new`);
-});
-
 test("fails instead of releasing when GitHub cannot supply release state", async () => {
   const { options } = fixture();
   options.github.paginate = async () => {
@@ -211,8 +171,3 @@ test("stable releases derive the version from legacy nightly tags", async () =>
   });
   assert.equal((await resolveLatestNightlyCommit(options)).version, "0.9.0");
 });
-
-test("stable releases fail without a published nightly", async () => {
-  const { options } = nightlyCommitFixture({ releases: [nightly(0, { tag_name: "v1.0.0" })] });
-  await assert.rejects(resolveLatestNightlyCommit(options), /No published nightly/);
-});

.github/scripts/thread-transfer-report.test.cjs

@@ -2,7 +2,6 @@ const assert = require("node:assert/strict");
 const test = require("node:test");
 
 const {
-  renderComment,
   resolve,
   upsertCommentForCurrentHead,
   validateResult,
@@ -53,39 +52,6 @@ test("validates the fixed artifact schema", () => {
   );
 });
 
-test("renders baseline, impact, ceiling, and ceiling changes", () => {
-  const baseline = result();
-  const current = result({ measuredTurnWebSocketWireBytes: 260_000 });
-  current.providers.codex.ceiling = {
-    ...current.providers.codex.ceiling,
-    measuredTurnWebSocketWireBytes: 330_000,
-  };
-  const comment = renderComment({
-    current,
-    baseline,
-    currentRun: {
-      sha: "bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb",
-      conclusion: "success",
-      url: "https://github.com/pingdotgg/t3code/actions/runs/2",
-    },
-    baselineRun: {
-      sha: "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
-      matchesBase: true,
-      url: "https://github.com/pingdotgg/t3code/actions/runs/1",
-    },
-  });
-
-  assert.match(comment, /Main baseline \| This PR \| Impact \| PR ceiling/);
-  assert.match(comment, /\+9\.8 KiB \(\+4\.0%\)/);
-  assert.match(comment, /This PR changes transfer ceilings/);
-  assert.match(comment, /312\.5 KiB → 322\.3 KiB/);
-  assert.match(comment, /<!-- t3-thread-transfer-report -->/);
-  assert.match(
-    comment,
-    /<!-- t3-thread-transfer-result-sha:bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb -->/,
-  );
-});
-
 test("resolves a fallback PR with a redacted head repo and exact main baseline", async () => {
   const outputs = {};
   const listWorkflowRunArtifacts = () => {};
@@ -373,21 +339,3 @@ test("preserves a successful result when a same-SHA rerun has no artifact", asyn
   assert.equal(published, true);
   assert.equal(updatedComment, false);
 });
-
-test("accepts V2 without comparing it to the V1 scenario", () => {
-  const current = result();
-  current.scenario.id = "thread-transfer-v2";
-  current.providers.codex.ceiling = { ...current.providers.codex.ceiling, totalWireBytes: 3000000 };
-  assert.equal(validateResult(current), current);
-  const comment = renderComment({
-    current,
-    baseline: result(),
-    currentRun: { sha: "bbbbbbbb", conclusion: "success", url: "https://example.com/current" },
-    baselineRun: { sha: "aaaaaaaa", matchesBase: true, url: "https://example.com/baseline" },
-  });
-  assert.match(comment, /fixture changed/);
-  assert.doesNotMatch(comment, /This PR changes transfer ceilings/);
-  assert.doesNotMatch(comment, /[+-]\d+\.\d+%/);
-  current.scenario.id = "unrecognized";
-  assert.throws(() => validateResult(current), /not supported/);
-});

.github/workflows/ci.yml

@@ -83,6 +83,14 @@ jobs:
       - name: Setup Vite+
         uses: ./.github/actions/setup-ci-deps
 
+      # electron's install.js (run by ensure:electron) reads this cache before it
+      # downloads from GitHub. The key changes only with the Electron version.
+      - name: Cache Electron download
+        uses: actions/cache@v6
+        with:
+          path: ~/.cache/electron
+          key: electron-${{ runner.os }}-${{ runner.arch }}-${{ hashFiles('node_modules/.pnpm/electron@*/node_modules/electron/package.json') }}
+
       - name: Ensure Electron runtime is installed
         run: vp run --filter @t3tools/desktop ensure:electron
 
@@ -131,6 +139,14 @@ jobs:
       - name: Setup Vite+
         uses: ./.github/actions/setup-ci-deps
 
+      # electron's install.js (run by ensure:electron) reads this cache before it
+      # downloads from GitHub. The key changes only with the Electron version.
+      - name: Cache Electron download
+        uses: actions/cache@v6
+        with:
+          path: ~/.cache/electron
+          key: electron-${{ runner.os }}-${{ runner.arch }}-${{ hashFiles('node_modules/.pnpm/electron@*/node_modules/electron/package.json') }}
+
       - name: Ensure Electron runtime is installed
         id: electron
         run: vp run --filter @t3tools/desktop ensure:electron
@@ -220,6 +236,14 @@ jobs:
       - name: Setup Vite+
         uses: ./.github/actions/setup-ci-deps
 
+      # electron's install.js (run by ensure:electron) reads this cache before it
+      # downloads from GitHub. The key changes only with the Electron version.
+      - name: Cache Electron download
+        uses: actions/cache@v6
+        with:
+          path: ~/.cache/electron
+          key: electron-${{ runner.os }}-${{ runner.arch }}-${{ hashFiles('node_modules/.pnpm/electron@*/node_modules/electron/package.json') }}
+
       - name: Ensure Electron runtime is installed
         run: vp run --filter @t3tools/desktop ensure:electron
 
@@ -250,6 +274,7 @@ jobs:
 
   # The web suite is the largest outside the server. In the shared Test job it
   # started last and ran alone for about 40s after everything else finished.
+  # release.yml mirrors this test, test_web, and test_server split.
   test_web:
     name: Test Web
     needs: changes