update Cargo.toml for release v2.6.0#1583
Merged
nikhilsinhaparseable merged 2 commits intoparseablehq:mainfrom Mar 15, 2026
Merged
update Cargo.toml for release v2.6.0#1583nikhilsinhaparseable merged 2 commits intoparseablehq:mainfrom
nikhilsinhaparseable merged 2 commits intoparseablehq:mainfrom
Conversation
Contributor
WalkthroughBump package version to 2.6.0 and update parseable_ui asset metadata; tighten JSON compatibility check for Timestamp values to disallow numeric JSON numbers (accept strings only). Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
nitisht
previously approved these changes
Mar 15, 2026
…tection Arrow's JSON decoder with coerce_primitive(false) cannot decode a JSON number (e.g., 1773595502.7462175) into a Timestamp field. it expects a string like "2026-03-15T17:13:59Z" this fixes the rejection when two log sources send same field - one as timestamp other as float number
3bf1dc4
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/event/format/mod.rs`:
- Around line 437-440: The comment near the Value::Number match arm incorrectly
asserts Arrow's JSON decoder rejects numeric JSON for Timestamp fields; update
the comment in src/event/format/mod.rs next to the Value::Number => false and
surrounding match logic to either remove the Arrow-specific claim or explicitly
state this is a Parseable-specific restriction (not an Arrow limitation).
Preserve the intended behavior if keeping the restriction, but change the
wording to reference our Parseable policy (or delete the inaccurate Arrow
reference) so the comment no longer misattributes behavior to Arrow's JSON
decoder.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 497ef8df-3abd-498d-9488-d2c62c53dee0
📒 Files selected for processing (1)
src/event/format/mod.rs
nitisht
approved these changes
Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Chores
Bug Fixes