Skip to content
This repository was archived by the owner on May 21, 2024. It is now read-only.

Split trappist and stout runtimes with conditional build#241

Merged
kalaninja merged 1 commit into
mainfrom
feature/conditional-build
Jun 28, 2023
Merged

Split trappist and stout runtimes with conditional build#241
kalaninja merged 1 commit into
mainfrom
feature/conditional-build

Conversation

@kalaninja

@kalaninja kalaninja commented Jun 27, 2023

Copy link
Copy Markdown
Contributor
  • make trappist-runtime and stout-runtime dependencies optional, both enabled by default
  • run tests for trappist only
  • add substrate version to cache key for manual cache invalidation on version upgrades
  • add custom free-space action to free more space. We are currently having cache misses because test job doesn't have enough space to pack the generated artifacts.
  • resolve Check why testing with benchmark is taking so long. #214

@kalaninja kalaninja force-pushed the feature/conditional-build branch 7 times, most recently from 36185ba to 4c31b3c Compare June 27, 2023 16:10
@kalaninja kalaninja changed the title split trappist and stout runtimes with conditional build Split trappist and stout runtimes with conditional build Jun 28, 2023
@kalaninja kalaninja force-pushed the feature/conditional-build branch from 4c31b3c to c233a98 Compare June 28, 2023 01:52
@kalaninja kalaninja force-pushed the feature/conditional-build branch from c233a98 to 2a77288 Compare June 28, 2023 04:36
Comment thread node/src/rpc.rs
Comment thread .github/templates/free-space/action.yaml
@kalaninja kalaninja merged commit 3ac372b into main Jun 28, 2023
@kalaninja kalaninja deleted the feature/conditional-build branch June 28, 2023 12:11

@evilrobot-01 evilrobot-01 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few general comments/suggestions and questions 🙂

Comment thread .github/workflows/check.yml
Comment thread .github/workflows/check.yml
Comment thread node/src/benchmarking.rs
Comment thread node/src/command.rs
Comment thread .github/templates/free-space/action.yaml
Comment thread node/src/benchmarking.rs
Comment thread node/src/service.rs
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check why testing with benchmark is taking so long.

3 participants