Skip to content
This repository was archived by the owner on May 21, 2024. It is now read-only.

ci: add deterministic build option#134

Merged
stiiifff merged 2 commits into
masterfrom
frank/feat-deterministic-build
Apr 5, 2023
Merged

ci: add deterministic build option#134
stiiifff merged 2 commits into
masterfrom
frank/feat-deterministic-build

Conversation

@evilrobot-01

@evilrobot-01 evilrobot-01 commented Feb 27, 2023

Copy link
Copy Markdown
Contributor

Quick PR based on https://docs.substrate.io/build/build-a-deterministic-runtime, adding an optional workflow which performs a deterministic build using Substrate Runtime Toolbox: srtool.

Workflows set as workflow_dispatch, so will only run on manual trigger.

@evilrobot-01 evilrobot-01 force-pushed the frank/feat-deterministic-build branch 3 times, most recently from db7f224 to 6177e46 Compare February 27, 2023 17:14
@evilrobot-01 evilrobot-01 force-pushed the frank/feat-deterministic-build branch from 6177e46 to 0b48242 Compare February 27, 2023 18:20
@evilrobot-01

evilrobot-01 commented Feb 27, 2023

Copy link
Copy Markdown
Contributor Author

Sample run at https://github.com/paritytech/trappist/actions/runs/4286565726. Summary step shows full output, resulting artifacts are wasm/json as .zip.

@evilrobot-01 evilrobot-01 marked this pull request as ready for review February 27, 2023 18:22
@evilrobot-01 evilrobot-01 marked this pull request as draft February 27, 2023 18:37
@evilrobot-01 evilrobot-01 force-pushed the frank/feat-deterministic-build branch 2 times, most recently from 91af055 to 6b5d966 Compare February 27, 2023 20:30
@evilrobot-01 evilrobot-01 force-pushed the frank/feat-deterministic-build branch from 6b5d966 to d30d197 Compare February 27, 2023 21:34
@evilrobot-01 evilrobot-01 marked this pull request as ready for review February 27, 2023 21:34
@stiiifff

Copy link
Copy Markdown
Contributor

Awesome contribution @evilrobot-01. I think this might come in handy at some point ... 🤓️

@hbulgarini

hbulgarini commented Mar 31, 2023

Copy link
Copy Markdown
Contributor

@stiiifff & @evilrobot-01 is there any reason why we didn't merge this PR yet? this change can be useful for #138

also you can merge this PR to this preparation branch: https://github.com/paritytech/trappist/tree/hb-deploy-preparation

@evilrobot-01

Copy link
Copy Markdown
Contributor Author

None from my side, guess perhaps as it wasn't a priority based on other things going on at the time.

I think it was just left for the future as and when required.

@hbulgarini hbulgarini mentioned this pull request Apr 4, 2023
12 tasks
@stiiifff

stiiifff commented Apr 5, 2023

Copy link
Copy Markdown
Contributor

LGTM

@stiiifff stiiifff merged commit 675d89b into master Apr 5, 2023
@stiiifff stiiifff deleted the frank/feat-deterministic-build branch April 5, 2023 08:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants