Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Revert "Decrease the peer reputation on invalid block requests (#8260)"#8309

Merged
bkchr merged 1 commit into
rococo-v1from
rk-revert-8260
Mar 10, 2021
Merged

Revert "Decrease the peer reputation on invalid block requests (#8260)"#8309
bkchr merged 1 commit into
rococo-v1from
rk-revert-8260

Conversation

@eskimor

@eskimor eskimor commented Mar 10, 2021

Copy link
Copy Markdown
Member

This reverts commit 7e5c307.

As it breaks rococo due to a bug in sync code.

@github-actions github-actions Bot added the A0-please_review Pull request needs code review. label Mar 10, 2021
@eskimor eskimor added A6-revertrevert B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Mar 10, 2021
@eskimor eskimor requested a review from bkchr March 10, 2021 11:23
@eskimor

eskimor commented Mar 10, 2021

Copy link
Copy Markdown
Member Author

bot merge

@ghost

ghost commented Mar 10, 2021

Copy link
Copy Markdown

Checks failed; merge aborted.

@eskimor

eskimor commented Mar 10, 2021

Copy link
Copy Markdown
Member Author

Who can merge this? The failing cargo deny checks are definitely not introduced via this PR.

@andresilva

andresilva commented Mar 10, 2021

Copy link
Copy Markdown
Contributor

I can merge it, but the main test job (gitlab-test-linux-stable) is still running and we should wait for that to finish.

@bkchr bkchr merged commit 645299e into rococo-v1 Mar 10, 2021
@bkchr bkchr deleted the rk-revert-8260 branch March 10, 2021 12:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants