Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Make offchain tx pool creation reusable#14230

Merged
paritytech-processbot[bot] merged 3 commits into
masterfrom
bkchr-offchain-tx-pool-factory
May 31, 2023
Merged

Make offchain tx pool creation reusable#14230
paritytech-processbot[bot] merged 3 commits into
masterfrom
bkchr-offchain-tx-pool-factory

Conversation

@bkchr

@bkchr bkchr commented May 25, 2023

Copy link
Copy Markdown
Member

Introduces an OffchainTransactionPoolFactory for creating offchain transactions pools that can be registered in the runtime externalities context. This factory will be required for a later pr to make the creation of offchain transaction pools easier.

Introduces an `OffchainTransactionPoolFactory` for creating offchain transactions pools that can be
registered in the runtime externalities context. This factory will be required for a later pr to
make the creation of offchain transaction pools easier.
@bkchr bkchr added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. B1-note_worthy Changes should be noted in the release notes T0-node This PR/Issue is related to the topic “node”. and removed B0-silent Changes should not be mentioned in any release notes labels May 25, 2023
@bkchr bkchr requested a review from a team May 28, 2023 10:59

@melekes melekes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread client/transaction-pool/api/src/lib.rs Outdated
@bkchr

bkchr commented May 31, 2023

Copy link
Copy Markdown
Member Author

bot merge

@paritytech-processbot

Copy link
Copy Markdown

Waiting for commit status.

@paritytech-processbot paritytech-processbot Bot merged commit 66ac9c4 into master May 31, 2023
@paritytech-processbot paritytech-processbot Bot deleted the bkchr-offchain-tx-pool-factory branch May 31, 2023 01:12
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
* Make offchain tx pool creation reusable

Introduces an `OffchainTransactionPoolFactory` for creating offchain transactions pools that can be
registered in the runtime externalities context. This factory will be required for a later pr to
make the creation of offchain transaction pools easier.

* Update client/transaction-pool/api/src/lib.rs

Co-authored-by: Anton <anton.kalyaev@gmail.com>

---------

Co-authored-by: Anton <anton.kalyaev@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. T0-node This PR/Issue is related to the topic “node”.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants