Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Assets: impl ContainsPair for asset and account IDs#14119

Merged
paritytech-processbot[bot] merged 2 commits into
masterfrom
muharem-asset-contains-account
May 11, 2023
Merged

Assets: impl ContainsPair for asset and account IDs#14119
paritytech-processbot[bot] merged 2 commits into
masterfrom
muharem-asset-contains-account

Conversation

@muharem

@muharem muharem commented May 10, 2023

Copy link
Copy Markdown
Contributor

Implementation of ContainsPair trait for Assets pallet, to check if an account with the given asset ID and account address exists.

@muharem muharem added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels May 10, 2023
@muharem muharem marked this pull request as ready for review May 10, 2023 15:16
@muharem muharem requested review from a team, bkchr, ggwpez and joepetrowski May 10, 2023 15:16
@KiChjang

Copy link
Copy Markdown
Contributor

Do you intend to use the pallet as a config item to IsReserve or IsTeleporter in the XCM config?

@muharem

muharem commented May 11, 2023

Copy link
Copy Markdown
Contributor Author

Do you intend to use the pallet as a config item to IsReserve or IsTeleporter in the XCM config?

no, it will be used in asset-conversion pallet to check if the system account already exist or should be created.

@muharem

muharem commented May 11, 2023

Copy link
Copy Markdown
Contributor Author

bot merge

@paritytech-processbot paritytech-processbot Bot merged commit c09f0bc into master May 11, 2023
@paritytech-processbot paritytech-processbot Bot deleted the muharem-asset-contains-account branch May 11, 2023 15:56
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
* Assets impl ContainsPair for asset and account IDs

* clap version
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants