This repository was archived by the owner on Nov 15, 2023. It is now read-only.
[trivial] add note on usage of twox hash#13089
Merged
Merged
Conversation
Ank4n
added
A0-please_review
rossbulat
approved these changes
Jan 6, 2023
rossbulat
left a comment
rossbulat
left a comment
There was a problem hiding this comment.
Does this satisfy a convention in substrate?
kianenigma
approved these changes
Jan 8, 2023
Contributor
Author
Added some more context in the description. Shawn's |
rossbulat
pushed a commit
that referenced
this pull request
Jan 11, 2023
ltfschoen
pushed a commit
to ltfschoen/substrate
that referenced
this pull request
Feb 22, 2023
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding some note to justify using twox hasher for storage maps where key is user generated.
Longer explanation
By convention, a storage map that has user generated key should use a cryptographic hasher (such as blake2). For storage maps which are populated by a signed
AccountIdas key though, it is fine to use twox hasher since generatedAccountIdis itself a secure hash.