This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Ignore peers that are not synced during sync status check#11705
Closed
nazar-pc wants to merge 1 commit into
Closed
Ignore peers that are not synced during sync status check#11705nazar-pc wants to merge 1 commit into
nazar-pc wants to merge 1 commit into
Conversation
Member
|
Hmm, how often do you really have 7000 syncing nodes? I'm not sure if that maybe opens some other attack vector. @arkpar WDYT? |
Contributor
Author
|
We're aiming for network with hundreds of thousands of nodes, so I guess the answer is... all the time? With over 25k of consensus nodes during non-incentivized testnet I can totally expect inrush of thousands of non-synced nodes into the network after some announcement and this is a potential attach vector that will cause extra forking. |
bkchr
added
A0-please_review
Contributor
Author
|
The way I see this, there isn't any benefit in looking at peers that are obviously not synced in determining whether local peer is synced, it can't possibly add any useful context, but it may hurt in specific cases. |
bkchr
approved these changes
Jun 19, 2022
Member
|
Makes sense to me |
Contributor
Author
|
Closing as obsolete after #11817 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses my comment from https://github.com/paritytech/substrate/pull/11547/files#r889214514
Basically there is no reason to take into account peers that have best number below ours.