Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Don't ban peers for small duplicate requests #11084

Merged
paritytech-processbot merged 2 commits into from
Mar 22, 2022
Merged

Don't ban peers for small duplicate requests #11084

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65477d2
Don't ban peers for small duplicate requests
nathanwhit Mar 21, 2022
b6e7bf3
Address review comment
nathanwhit Mar 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion client/network/src/block_request_handler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,10 @@ mod rep {

/// Reputation change when a peer sent us the same request multiple times.
pub const SAME_REQUEST: Rep = Rep::new_fatal("Same block request multiple times");

/// Reputation change when a peer sent us the same "small" request multiple times.
pub const SAME_SMALL_REQUEST: Rep =
Rep::new(-(1 << 10), "same small block request multiple times");
}

/// Generates a [`ProtocolConfig`] for the block request protocol, refusing incoming requests.
Expand Down Expand Up @@ -200,8 +204,16 @@ impl<B: BlockT> BlockRequestHandler<B> {
Some(SeenRequestsValue::Fulfilled(ref mut requests)) => {
*requests = requests.saturating_add(1);

let small_request = attributes
.difference(BlockAttributes::HEADER | BlockAttributes::JUSTIFICATION)
.is_empty();

if *requests > MAX_NUMBER_OF_SAME_REQUESTS_PER_PEER {
reputation_change = Some(rep::SAME_REQUEST);
reputation_change = Some(if small_request {
rep::SAME_SMALL_REQUEST
} else {
rep::SAME_REQUEST
});
}
},
None => {
Expand Down