This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Warn about usage of pallet collective set members call.#10156
Merged
Conversation
gui1117
added
A2-insubstantial
joepetrowski
reviewed
Nov 2, 2021
joepetrowski
reviewed
Nov 2, 2021
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
emostov
approved these changes
Nov 10, 2021
bkchr
approved these changes
Nov 11, 2021
Contributor
|
bot merge |
ordian
added a commit
that referenced
this pull request
Nov 12, 2021
* master: (27 commits) Bump rustversion from 1.0.4 to 1.0.5 (#10243) Kill the light client, CHTs and change tries. (#10080) tuple to struct event variants (#10206) Bump thiserror from 1.0.26 to 1.0.30 (#10240) Warn about usage of pallet collective set members call. (#10156) Bump git2 from 0.13.22 to 0.13.23 (#10238) Add group name in task metrics (#10196) Bump proc-macro-crate from 1.0.0 to 1.1.0 (#10237) Bump parity-util-mem from 0.10.0 to 0.10.2 (#10236) Bump substrate-bip39 from 0.4.2 to 0.4.4 (#10213) Upgrade jsonrpsee to v0.4.1 (#10022) expose substrate-cli service (#10229) Intend to reactivate cargo-unleash check (#10167) CI: build docs with deps (#9884) use CountedMap in pallet-bags-list (#10179) Move all example pallets under `examples` folder. (#10215) Upgrade wasm builder (#10226) upgrade ss58-registry with additional networks. (#10224) move wiki -> docs (#10225) new remote-ext mode: (#10192) ...
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
…0156) * warn * Apply suggestions from code review Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com> * fmt Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
…0156) * warn * Apply suggestions from code review Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com> * fmt Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the pallet collective allows other pallet to manage the member set through the implementation of
ChangeMembersbut also directly withset_membersroot call.But both are quite incompatible. Or at least they must stay in sync.
Like currently on kusama if we call
set_memberswithout modifying the storage of pallet-membership they would get out of sync.And the next call to
change_membersfrom pallet-membership will be inaccurate in regards to who are the member in pallet-collective.I think this call is a bit error prone.