fix: add support for Parallel and Heiko#1012
Conversation
|
hey @MrPai Please see this comment I put on a similar PR that was just submitted: #1009 (comment) Same applies to you in terms of keeping the PR up. |
|
@TarikGul reviewed the explaining in another PR, thanks for it, if it's possible to merge it if you think the PR is ok, because one of our cooperative partners relies on your repo, hope this will not block them for testing and developing. |
| ("heiko", _v) => V2(new_u128(inner)), | ||
| ("parallel", _v) => V2(new_u128(inner)), | ||
|
|
There was a problem hiding this comment.
@MrPai Thank you for your PR!
As already mentioned, if you would like this PR to be merged ASAP you can do the following :
- Revert/remove this change in
calc_feeand - Revert change in
calc/pkg/calc_bg.wasm - Change the title of the PR to something that it reflects the change in the chains config, e.g. "fix: add support (controllers) for Parallel and Heiko" (just an example).
Regarding the fee calculation, adding anything to calc_fee will not have any impact since we do not use it anymore. Please check the related comments here and here by Tarik and James.
Having said that, for fees we are advising to use the ?feeByEvent=true query param found in the /blocksrelated endpoints. Please check also the endpoints docs where it mentions more details on feeByEvent :
When set to true, extrinsics will have their fees retrieved by their events. This query param will use a fee estimation via rpc::payment::query_info to accurately identify which event has the corresponding fee information that is closest to the value provided by query_info.
There was a problem hiding this comment.
@Imod7 thanks for your information, I have done what you mentioned, please take a look.
This reverts commit 37e5d64.
mclyk
changed the title
|
@MrPai Hey LGTM, it'll go in tomorrow, then a release will happen on tuesday which will include these changes. It's still Sunday for the team so it will get another review tomorrow. |
|
@TarikGul Thanks, have a nice day. |
3 participants
No description provided.