This repository was archived by the owner on Nov 15, 2023. It is now read-only.
fix log targets for nonfungibles-adapter#7154
Merged
paritytech-processbot[bot] merged 3 commits intoMay 2, 2023
Merged
Conversation
vstam1
added
A2-insubstantial
mrcnski
approved these changes
May 1, 2023
mrcnski
left a comment
mrcnski
left a comment
Contributor
There was a problem hiding this comment.
nit: Should it match the name of the file, i.e. xcm::nonfungibles_adapter (no first underscore)? Otherwise someone may try something like RUST_LOG=xcm::nonfungibles_adapter=trace and nothing would show up.
KiChjang
approved these changes
May 1, 2023
sam0x17
approved these changes
May 1, 2023
liamaharon
approved these changes
May 1, 2023
bkchr
reviewed
May 1, 2023
| ) -> result::Result<xcm_executor::Assets, XcmError> { | ||
| log::trace!( | ||
| target: "xcm::non_fungibles_adapter", | ||
| target: "xcm::nonfungibles_adapter", |
Member
There was a problem hiding this comment.
Please create a constant LOG_TARGET: &str = "xcm::nonfungibles_adapter" instead of copying thus here all the time.
Contributor
Author
|
bot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.