This repository was archived by the owner on Nov 15, 2023. It is now read-only.
XCM: Limit the max number of assets weighable in MultiAssets#6786
Merged
Conversation
KiChjang
added
A0-please_review
gavofyork
reviewed
Feb 25, 2023
gavofyork
reviewed
Feb 25, 2023
gavofyork
reviewed
Feb 25, 2023
gavofyork
approved these changes
Feb 25, 2023
gavofyork
left a comment
gavofyork
left a comment
Member
There was a problem hiding this comment.
After my suggestions, this seems ok.
Contributor
|
Some tests will be helpful |
Co-authored-by: Gavin Wood <gavin@parity.io>
gavofyork
reviewed
Feb 26, 2023
gavofyork
reviewed
Feb 26, 2023
gavofyork
reviewed
Feb 26, 2023
gavofyork
reviewed
Feb 26, 2023
Member
|
Looks fine - will need another review though. |
bkontur
approved these changes
Feb 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To prevent unreasonably high count values from overweighing related XCM instructions, we should have an upper limit on how many assets we would weight during the weight calculation of XCM.