uint: Make is_zero implementation const#639
Merged
Merged
Conversation
Contributor
Author
|
@niklasad1 I need someone else to approve here, because 2 reviews are required. |
arkpar
approved these changes
Apr 4, 2022
kianenigma
reviewed
Apr 5, 2022
| let &$name(ref arr) = self; | ||
| for i in 0..$n_words { if arr[i] != 0 { return false; } } | ||
| let mut i = 0; | ||
| while i < $n_words { if arr[i] != 0 { return false; } else { i += 1; } } |
There was a problem hiding this comment.
so while is now stable to loop over in const context but for not yet? interesting, seemed like all of them are behind const_looping
Contributor
Author
There was a problem hiding this comment.
Yeah, for loop calls iter.next() which is not a const fn.
Future RFCs (like rust-lang/rfcs#2237) might lift that restriction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #638
forloops are not allowed in const functions, so I went with simplewhileloop approach.