This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Add Ability to Add/Remove Invulnerable Collators#2596
Merged
Conversation
joepetrowski
added
A0-please_review
Ank4n
reviewed
May 21, 2023
Ank4n
reviewed
May 21, 2023
Ank4n
reviewed
May 21, 2023
Ank4n
reviewed
May 21, 2023
Ank4n
approved these changes
May 22, 2023
bkchr
approved these changes
May 24, 2023
bkchr
left a comment
bkchr
left a comment
Member
There was a problem hiding this comment.
Some changes to the migration to ensure that it works properly.
Co-authored-by: Bastian Köcher <git@kchr.de>
joepetrowski
commented
May 24, 2023
gpestana
approved these changes
May 26, 2023
gpestana
left a comment
gpestana
left a comment
There was a problem hiding this comment.
Added a couple of suggestions in the tests, but overall lgmt.
kianenigma
reviewed
May 29, 2023
kianenigma
reviewed
May 29, 2023
kianenigma
reviewed
May 29, 2023
kianenigma
approved these changes
May 29, 2023
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Contributor
Author
|
bot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First step in a larger improvement, allowing the ability to add or remove individual collators to/from the
Invulnerablesset. Individuals can use this to propose themselves as invulnerables without needing to propose an entire set.This was discussed in https://forum.polkadot.network/t/economic-model-for-system-para-collators/1010
A follow up will be to address paritytech/polkadot-sdk#106
Supersedes #2144